Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out - 1.26.x #9165

Merged
merged 1 commit into from
Jun 19, 2021
Merged

Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out - 1.26.x #9165

merged 1 commit into from
Jun 19, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 17, 2021 •
edited by kjozwiak
Loading

Uplift of #9160
Resolves brave/brave-browser#16357

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team June 17, 2021 18:47
@tmancey tmancey self-assigned this Jun 17, 2021
@tmancey tmancey changed the title Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out - 1.26.x Jun 17, 2021
@kjozwiak kjozwiak mentioned this pull request Jun 18, 2021
Merged
24 tasks
@kjozwiak
Copy link
Member

Waiting till #9160 gets merged into master so QA can get a Nightly and run through a quick verification before uplifting.

@tmancey tmancey added this to the 1.26.x - Release milestone Jun 18, 2021
kjozwiak
kjozwiak approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.26.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#16357 (comment).

@kjozwiak kjozwiak merged commit cbadc1e into 1.26.x Jun 19, 2021
@kjozwiak kjozwiak deleted the issues/16357-1.26.x branch June 19, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.26.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak