Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Safe Browsing client-side phishing detection model is downloaded #16379

Closed
fmarier opened this issue Jun 12, 2021 · 1 comment · Fixed by brave/brave-core#9813
Closed

Comments

@fmarier
Copy link
Member

fmarier commented Jun 12, 2021

At first run, Brave browsers fetch the following file from Google (via Brave proxy):

   GET https://static.brave.com/safebrowsing/csd/client_model_v5_variation_6.pb HTTP/2.0
       ← 200 application/octet-stream 80.13k 159ms

I'm pretty sure that feature is disabled in Brave and so this is unnecessary.

@stephendonner
Copy link

stephendonner commented Aug 30, 2021

Verified PASSED using

Brave 1.30.56 Chromium: 93.0.4577.58 (Official Build) beta (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. new profile
  2. launched Charles Proxy
  3. launched Brave
  4. ran through I ran through all of the Webpage and Desktop Download tests on https://testsafebrowsing.appspot.com/ successfully.
  5. checked Charles Proxy for both imefjhfbkmcmebodilednhmaccmincoa and any calls to static.brave.com.

Confirmed:

  1. no requests from imefjhfbkmcmebodilednhmaccmincoa
  2. no calls to static.brave.com nor ssl.gstatic.com
  3. the tests worked identically to my run using 1.28.106

Screen Shot 2021-08-30 at 2 52 48 PM


Verification passed on

Brave | 1.30.59 Chromium: 93.0.4577.58 (Official Build) beta (64-bit)
-- | --
Revision | c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Confirmed:

  1. ran through I ran through all of the Webpage and Desktop Download tests on https://testsafebrowsing.appspot.com/ successfully.
  2. no requests from imefjhfbkmcmebodilednhmaccmincoa
  3. no calls to static.brave.com nor ssl.gstatic.com

image


Verification passed on

Brave 1.30.81 Chromium: 94.0.4606.50 (Official Build) (64-bit)
Revision 0c1ac2c4842a4746c27c937c1a0453f98da1a972-refs/branch-heads/4606@{#1049}
OS Ubuntu 18.04 LTS

Confirmed:

  1. ran through I ran through all of the Webpage and Desktop Download tests on https://testsafebrowsing.appspot.com/ successfully.
  2. no requests from imefjhfbkmcmebodilednhmaccmincoa
  3. no calls to static.brave.com nor ssl.gstatic.com

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants