Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr93 followup]: Hide "Set up new Brave profile" page when adding a new profile in profile picker. #17552

Closed
mkarolin opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#9789
Closed

[cr93 followup]: Hide "Set up new Brave profile" page when adding a new profile in profile picker. #17552

mkarolin opened this issue Aug 19, 2021 · 1 comment · Fixed by brave/brave-core#9789
Assignees
@mkarolin
Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.29.x - Release

Comments

@mkarolin
Copy link
Contributor

STR:

  1. In Brave window, click on ☰ -> Create a new profile
  2. Observe popup window showing Set up page:
    image

Expected result:
Popup goes directly to the next page (same as clicking "Continue without an account" button):
image
@mkarolin mkarolin mentioned this issue Aug 19, 2021
Merged
24 tasks
@mkarolin mkarolin self-assigned this Aug 19, 2021
@mkarolin mkarolin mentioned this issue Aug 19, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Aug 19, 2021
@mkarolin
[cr93 followup] Fixes profile picker - hides "Set up" page.
b14babe 
Fixes brave/brave-browser#17552

Overrides call to AccountConsistencyModeManager::IsDiceSignInAllowed in
profile_picker_ui.cc to return false so that the page isn't shown. There
is a feature flag (features::kSignInProfileCreation) to do the same, but
the flag is already removed in cr94, so this should be a more durable
solution.
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 20, 2021
@mkarolin mkarolin added this to the 1.30.x - Nightly milestone Aug 20, 2021
@mkarolin mkarolin mentioned this issue Aug 23, 2021
Merged
24 tasks
@stephendonner
Copy link

stephendonner commented Aug 26, 2021 •
edited
Loading

Verified PASSED using

Brave 1.29.74 Chromium: 93.0.4577.58 (Official Build) (x86_64)
Revision c4410ece044414ea42fa4ba328d08195e818a99c-refs/branch-heads/4577@{#1076}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

  1. clean profile
  2. launch Brave
  3. click on ☰ and choose Create a New Profile

Confirmed it goes to the Customize your Brave profile dialog.

Screen Shot 2021-08-27 at 9 49 24 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging a pull request may close this issue.

[cr93 followup] Fixes profile picker - hides "Set up" page. brave/brave-core
4 participants
@stephendonner @kjozwiak @rebron @mkarolin