-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use side-panel's bookmark part as sidebar's bookmark panel #20500
Comments
Found the reason why some features of read-later page(brave://read-later.top-chrome) doesn't work in the sidebar panel |
One more thing - we may want to display side panel's bookmark part at sidebar regardless of upstream's side-panel feature flag state. |
fix brave/brave-browser#20500 Applied bookmark part of chromium's side panel to sidebar bookmark panel. sidebar.mojom is used for interacting between sidebar's bookmarks panel with SidebarBookmarksPageHandler. Most of webui impls in browser/resources/sidebar/bookmarks are copied from upstream and modified to show bookmark part only. (side panel's page shows read later and bookmark part both.) Bookmarks page uses custom context menu by asking to native via Sidebar:ShowCustomContextMenu interface.
fix brave/brave-browser#20500 Applied bookmark part of chromium's side panel to sidebar bookmark panel. sidebar.mojom is used for interacting between sidebar's bookmarks panel with SidebarBookmarksPageHandler. Most of webui impls in browser/resources/sidebar/bookmarks are copied from upstream and modified to show bookmark part only. (side panel's page shows read later and bookmark part both.) Bookmarks page uses custom context menu by asking to native via Sidebar:ShowCustomContextMenu interface.
fix brave/brave-browser#20500 Applied bookmark part of chromium's side panel to sidebar bookmark panel. sidebar.mojom is used for interacting between sidebar's bookmarks panel with SidebarBookmarksPageHandler. Most of webui impls in browser/resources/sidebar/bookmarks are copied from upstream and modified to show bookmark part only. (side panel's page shows read later and bookmark part both.) Bookmarks page uses custom context menu by asking to native via Sidebar:ShowCustomContextMenu interface.
Verified
|
Brave | 1.37.36 Chromium: 98.0.4758.87 (Official Build) nightly (64-bit) |
---|---|
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002} |
OS | Windows 10 Version 21H2 (Build 19044.1466) |
Steps:
- new profile
- open
brave://flags/
- set
Enable Sidebar
toEnabled
- restart Brave
- click on the
Bookmarks
icon in Sidebar
Tested the following:
Context-menu
- Open in New Tab
- Open in New Window
- Open in Private Window
- Edit...
- Cut
- Copy
- Paste
- Delete
- Add Page...
- Add Folder...
- Bookmark Manager
drag and drop from brave://bookmarks <-> Bookmarks in Sidebar
drag and drop from desktop -> Bookmarks in Sidebar
example | example | example | example | example |
---|---|---|---|---|
example | example | example | example | example |
---|---|---|---|---|
Also tested multi-selection context menu items (Open all (9)
)
Filed:
#20995
#20996
#21000
#21004
And still testing 😉
Verification passed on
Brave | 1.37.86 Chromium: 99.0.4844.51 (Official Build) beta (64-bit) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | Ubuntu 18.04 LTS |
Verified the following:
- Open in New Tab
- Open in New Window
- Open in Private Window
- Edit...
- Cut
- Copy
- Paste
- Delete
- Add Page...
- Add Folder...
Drag and drop within bookmark panel
Drag and drop between bookmark panel and bookmark manager
Verified PASSED
using the above testcases with
Brave | 1.37.91 Chromium: 99.0.4844.51 (Official Build) beta (x86_64) |
---|---|
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875} |
OS | macOS Version 12.3 (Build 21E230) |
Load below side panel's bookmark part to sidebar bookmarks
The text was updated successfully, but these errors were encountered: