Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't be able to add 2 separate Bookmarks icons to Sidebar? #20996

Closed
stephendonner opened this issue Feb 9, 2022 · 2 comments
Closed

Shouldn't be able to add 2 separate Bookmarks icons to Sidebar? #20996

stephendonner opened this issue Feb 9, 2022 · 2 comments

Comments

@stephendonner
Copy link

Description

Shouldn't be able to add 2 separate Bookmarks icons to Sidebar?

Steps to Reproduce

  1. install 1.36.37
  2. load brave://flags
  3. set Enable Sidebar to Enabled
  4. click RELAUNCH
  5. click on the Bookmarks icon in Sidebar
  6. context-click on a folder
  7. choose Bookmark manager (brave://bookmarks)
  8. hover on the + in Sidebar
  9. choose bookmarks under Add to Sidebar

Actual result:

You now have two (2) Bookmarks icons in Sidebar (both work, but it's redundant). One opens the view in Sidebar; the other opens the Bookmarks Manager window proper.

Screen Shot 2022-02-09 at 9 05 10 AM

Expected result:

Only 1? The original, smaller-sized icon?

Screen Shot 2022-02-09 at 9 07 49 AM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.37.36 Chromium: 98.0.4758.87 (Official Build) nightly (x86_64)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS macOS Version 11.6.1 (Build 20G224)

I don't know if this is actually a bug, now that I think about it. But the UX can be a little confusing here.

cc @simonhong @bsclifton

@bsclifton
Copy link
Member

@simonhong is this still an issue?

@simonhong
Copy link
Member

Oops, I didn't know about this issue.
This issue was resolved by brave/brave-core#12311
Closed as duplicated with #21124

@simonhong simonhong added the closed/duplicate Issue has already been reported label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants