Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Monthly Contributions to be Monthly Tips #20564

Closed
7 tasks
Miyayes opened this issue Jan 19, 2022 · 3 comments · Fixed by brave/brave-core#12416
Closed
7 tasks

Change Monthly Contributions to be Monthly Tips #20564

Miyayes opened this issue Jan 19, 2022 · 3 comments · Fixed by brave/brave-core#12416
Assignees
@mkarolin
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.38.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 19, 2022 •
edited
Loading

Description

  • Rename "Monthly Contributions" to "Monthly Tips"
  • Reorder the Monthly Tips component in brave://rewards settings page to be last position (3rd), and move Tips section up into 2nd position
  • Fix description text in Monthly Tips component to be "Set up recurring monthly tips so you can continually support your favorite creators".
  • Change line item text to be "Total monthly tips this month"
  • Change line item text to be "Next monthly tip date"
  • Change any relevant "Monthly contributions" language in Tipping banner
  • Change any relevant "Monthly contributions" language in the Wallet Activity section

image
@Miyayes Miyayes added OS/Android Fixes related to Android browser functionality QA/Yes labels Jan 19, 2022
@zenparsing
Copy link

We should also check the tipping banner for any text changes that need to be made.

@zenparsing zenparsing added the priority/P4 Planned work. We expect to get to it "soon". label Jan 19, 2022
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Jan 19, 2022
@mkarolin mkarolin mentioned this issue Feb 25, 2022
Merged
25 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Feb 25, 2022
@mkarolin
Replace 'Monthly Contributions' language with 'Monthly Tips'
7b99cc4 
Fixes brave/brave-browser#20564
mkarolin added a commit to brave/brave-core that referenced this issue Mar 2, 2022
@mkarolin
Replace 'Monthly Contributions' language with 'Monthly Tips'
fb108dc 
Fixes brave/brave-browser#20564
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Mar 6, 2022
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 1, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 4, 2022 •
edited
Loading

Brave 1.38.78 Chromium: 100.0.4896.60 (Official Build) beta (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 11 Version 21H2 (Build 22000.593)

Note: For this testing, I have compared 1.38.78 to1.37.109 RC build to verify the text.

  • Install 1.38.78
  • Launch Brave
  • Rewards page
    • Navigate to brave://rewards
    • Verified renaming of the title: Monthly Contributions==> Monthly Tips
    • Verified reorder of Monthly Tips and Tips components
      • Monthly Tips has been moved to last position
      • Tips section has been moved up above Monthly Tips
    • Verified the description text for Monthly Tips component is updated
      • Set up recurring monthly contributions so you can support sites continuously ==> Set up recurring monthly tips so you can continually support your favorite creators.
    • Verified line item text renamed in Monthly Tips component:
      • Total contributions this month ==>Total Monthly tips this month
      • Next monthly contribution date ==> Next monthly tips date
  • Rewards Statement/Wallet
    • Click View Statement in the summary box
    • Verified the text update for Monthly Contributions in the rewards statement :
      • Monthly Contributions==>Monthly Tips
  • BRE panel
    • Visited a site https://wikipedia.com
    • Clicked on Rewards icon
    • Verified text update for Monthly Contributions in BRE Panel
      • Monthly Contributions==>Monthly Tips
  • Tipping Banner
    • Visited a site https://wikipedia.com
    • Clicked on Rewards icon
    • Clicked Send Tip button
    • toggle to Monthly
    • Verified text update for Monthly contributions in Tipping banner
      • Set monthly contribution--> Set monthly tip
      • Current monthly contribution===>Current monthly tip
      • Monthly contribution has been set--> Monthly tip has been set
      • Contribution amount===> Tip amount
      • Next contribution date ===>Next tip date
ex1 ex2 ex3 ex4 ex5 ex6 ex7 ex8
Monthly tips Monthly tips description text Monthly Tips line item text BRE Panel- Monthly tips text Tipping banner monthly tip set Monthly contribution set tipping banner-next tip

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 4, 2022
@Uni-verse
Copy link
Contributor

Verified using 1.38.103, Chromium 100.0.4896.127 on Samsung GS21 & Samsung Galaxy Tab S7 running Android 12

Acceptance Criteria

PASS - Rename "Monthly Contributions" to "Monthly Tips"
PASS - Reorder the Monthly Tips component in brave://rewards settings page to be last position (3rd), and move Tips section up into 2nd position
PASS - Fix description text in Monthly Tips component to be "Set up recurring monthly tips so you can continually support your favorite creators".
PASS - Change line item text to be "Total monthly tips this month"
PASS - Change line item text to be "Next monthly tip date"
PASS- Change any relevant "Monthly contributions" language in Tipping banner
PASS - Change any relevant "Monthly contributions" language in the Wallet Activity section

1 2 3 4
Screen Shot 2022-04-20 at 2 38 48 PM Screen Shot 2022-04-20 at 2 44 04 PM Screen Shot 2022-04-20 at 2 44 15 PM Screen Shot 2022-04-20 at 2 45 01 PM
1 2 3
Screen Shot 2022-04-20 at 2 47 59 PM Screen Shot 2022-04-20 at 2 48 13 PM Screen Shot 2022-04-20 at 2 48 47 PM

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Apr 27, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.38.109 for Desktop, Android will follow shortly
c84c5af 
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA Pass - Android Tab QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Replace 'Monthly Contributions' language with 'Monthly Tips' brave/brave-core
6 participants
@bsclifton @zenparsing @Miyayes @Uni-verse @mkarolin @MadhaviSeelam