Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue executing all cosmetic scriptlets even if one fails #21932

Closed
antonok-edm opened this issue Mar 28, 2022 · 5 comments · Fixed by brave/brave-core#12782
Closed

Continue executing all cosmetic scriptlets even if one fails #21932

antonok-edm opened this issue Mar 28, 2022 · 5 comments · Fixed by brave/brave-core#12782
Assignees
@antonok-edm
Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include uBO-parity
Milestone
1.38.x - Release

Comments

@antonok-edm
Copy link
Collaborator

brave/adblock-lists#811 was intended to fix the anti-Brave page on https://www.uploadbank.com/yt9ri1rtc0fg, but the scriptlets are not injecting correctly. Each scriptlet needs to be wrapped in a try/catch block to prevent this from happening, like uBlock Origin does.
@antonok-edm antonok-edm added bug feature/shields/adblock Blocking ads & trackers with Shields QA/Yes release-notes/include uBO-parity OS/Android Fixes related to Android browser functionality OS/Desktop labels Mar 28, 2022
@antonok-edm antonok-edm self-assigned this Mar 28, 2022
@antonok-edm antonok-edm mentioned this issue Mar 28, 2022
Merged
25 tasks
@antonok-edm antonok-edm added this to the 1.39.x - Nightly milestone Mar 28, 2022
@brave-builds brave-builds mentioned this issue Mar 28, 2022
Merged
7 tasks
@stephendonner
Copy link

stephendonner commented Mar 31, 2022 •
edited
Loading

Verified PASSED using

Brave 1.38.75 Chromium: 100.0.4896.60 (Official Build) beta (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

Steps:

  1. installed 1.38.75
  2. launched Brave
  3. loaded https://www.uploadbank.com/yt9ri1rtc0fg
  4. clicked through acknowledgement checkboxes and a CAPTCHA
  5. clicked on Download

Confirmed I was served the correct file without any warnings/roadblocks/interstitials

example example example example example
Screen Shot 2022-03-31 at 12 03 58 PM Screen Shot 2022-03-31 at 12 04 13 PM Screen Shot 2022-03-31 at 12 04 16 PM Screen Shot 2022-03-31 at 12 04 20 PM Screen Shot 2022-03-31 at 12 04 24 PM

@MadhaviSeelam
Copy link

Verified Passed using

Brave 1.38.80 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)

Steps:

  • Installed 1.38.80
  • launched Brave
  • loaded https://www.uploadbank.com/yt9ri1rtc0fg
  • clicked through acknowledgement checkboxes and a CAPTCHA
  • clicked on Download
  • Confirmed I was served the correct file without any warnings/roadblocks/interstitials
ex1 ex2 ex3 ex4 ex5
screenshot1 screenshot2 screenshot3 screenshot4 screenshot5

@btlechowski
Copy link

Verification passed on

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Ubuntu 18.04 LTS
  • Confirmed I was served the correct file without any warnings/roadblocks/interstitials
image image image image image

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 20, 2022 •
edited
Loading

Verification completed using 1.38.103, Chromium 100.0.4896.127 on Samsung Galaxy S21 running Android 12

Test URL: https://www.uploadbank.com/yt9ri1rtc0fg

  • Confirmed I was served the correct file without any warnings/roadblocks/interstitials
1 2 3 4 5
Screen Shot 2022-04-20 at 4 50 27 PM Screen Shot 2022-04-20 at 4 51 10 PM Screen Shot 2022-04-20 at 4 51 28 PM Screen Shot 2022-04-20 at 4 52 28 PM Screen Shot 2022-04-20 at 4 49 13 PM

@Uni-verse
Copy link
Contributor

Verification completed using 1.38.103, Chromium 100.0.4896.127 on Samsung Galaxy Tab S7 running Android 12

Test URL: https://www.uploadbank.com/yt9ri1rtc0fg

  • Confirmed I was served the correct file without any warnings/roadblocks/interstitials
1 2 3 4
Screen Shot 2022-04-20 at 4 58 17 PM Screen Shot 2022-04-20 at 4 58 35 PM Screen Shot 2022-04-20 at 4 58 49 PM Screen Shot 2022-04-20 at 5 01 43 PM

@LaurenWags LaurenWags mentioned this issue Apr 26, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Apr 27, 2022
Closed
avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
Brave Browser 1.38.109 for Desktop, Android will follow shortly
c84c5af 
 - Added the ability to redirect an AMP page to its canonical non-AMP version. ([#20458](brave/brave-browser#20458))
 - Added "Select network" field in the Brave Wallet "Add custom asset" modal. ([#21656](brave/brave-browser#21656))
 - Added isBraveWallet property to window.ethereum. ([#21949](brave/brave-browser#21949))
 - Added the ability to copy Brave Wallet transaction hash from "Transactions" on the "Portfolio" page. ([#19886](brave/brave-browser#19886))
 - Added confirmation screen after transaction is approved for Brave Wallet. ([#21733](brave/brave-browser#21733))
 - Added bottom padding to the Brave Wallet swap container. ([#21340](brave/brave-browser#21340))
 - Added loading skeletons for various areas within Brave Wallet. ([#21339](brave/brave-browser#21339))
 - Implemented balance updater interval for Brave Wallet. ([#21304](brave/brave-browser#21304))
 - Updated design for Brave Shields. ([#18630](brave/brave-browser#18630))
 - Updated IPFS node to go-ipfs v0.12.0. ([#21219](brave/brave-browser#21219))
 - Updated adblocking to execute all cosmetic scriptlets even if one fails. ([#21932](brave/brave-browser#21932))
 - Updated wording on Brave Wallet backup reminder banner. ([#21312](brave/brave-browser#21312))
 - Updated Brave Wallet swap capability to prevent unnecessarily encountering "Too many decimal places" error. ([#21527](brave/brave-browser#21527))
 - Updated URL for Brave Wallet Ropsten Test Faucet network. ([#21240](brave/brave-browser#21240))
 - Updated Brave Wallet password field to be cleared when an incorrect password is entered. ([#21010](brave/brave-browser#21010))
 - Updated "Portfolio" page of Brave Wallet to return all EVM network tokens. ([#20854](brave/brave-browser#20854))
 - Updated UI to increase spacing between "Assets" and "Transactions" on "Accounts" subview page of Brave Wallet. ([#21532](brave/brave-browser#21532))
 - Updated link text color to blue for Brave Wallet onboarding screen. ([#20302](brave/brave-browser#20302))
 - Updated alignment of options available from the Brave Wallet "More" menu. ([#19680](brave/brave-browser#19680))
 - Renamed "Monthly Contributions" to "Monthly Tips" for Brave Rewards. ([#20564](brave/brave-browser#20564))
 - Removed redirect after adding an account to Brave Wallet from the portfolio asset details screen. ([#19138](brave/brave-browser#19138))
 - Removed referral code from P3A reports. ([#21460](brave/brave-browser#21460))
 - Fixed unexpected storage cleanup on site close when "Clear cookies and site data when you close all windows" is enabled under brave://settings/cookies. ([#22493](brave/brave-browser#22493))
 - Fixed unblocked cookie consent dialogs on some websites when the brave://flags/#brave-adblock-cookie-list-default is enabled. ([#22032](brave/brave-browser#22032))
 - Fixed inability to solve Brave Rewards CAPTCHA in certain cases. ([#22180](brave/brave-browser#22180))
 - Fixed inability to import MetaMask wallet to Brave Wallet. ([#22492](brave/brave-browser#22492))
 - Fixed failed second sign request (eth_signTypedData_v4) for Loopring.io L2 activation when using Brave Wallet. ([#22070](brave/brave-browser#22070))
 - Fixed data on "Portfolio" page of Brave Wallet not being properly displayed due to parsing error. ([#21941](brave/brave-browser#21941))
 - Fixed broken placeholder icons for ERC721 tokens on Brave Wallet "Account" page. ([#21549](brave/brave-browser#21549))
 - Fixed "JSON data is not expected" when trying to import a crypto wallet into Brave Wallet in certain cases. ([#19526](brave/brave-browser#19526))
 - Fixed Brave Wallet network selector list being partially blurred on page load. ([#21423](brave/brave-browser#21423))
 - Fixed Brave Wallet "Add Custom Asset" modal incorrectly being populated with previously added custom token details. ([#21337](brave/brave-browser#21337))
 - Fixed EIP-1559 gas oracle incorrectly firing on non-EIP-1559 networks for Brave Wallet. ([#21107](brave/brave-browser#21107))
 - Fixed Brave Wallet percentage selector remaining selected when input value was updated. ([#20315](brave/brave-browser#20315))
 - Fixed Speedreader icon incorrectly disappearing in certain cases. ([#18243](brave/brave-browser#18243))
 - Fixed inability to exit reader mode when Speedreader is disabled. ([#18242](brave/brave-browser#18242))
 - Upgraded Chromium to 101.0.4951.41. ([#22431](brave/brave-browser#22431)) ([Changelog for 101.0.4951.41](https://chromium.googlesource.com/chromium/src/+log/100.0.4896.127..101.0.4951.41?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include uBO-parity
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Update adblock-rust to v0.5.1 brave/brave-core
7 participants
@stephendonner @kjozwiak @Uni-verse @antonok-edm @LaurenWags @btlechowski @MadhaviSeelam