Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add as a separate shortcut when built-in provide related item #12311

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 17, 2022

fix brave/brave-browser#21124

When bookmarks manager is loaded in active tab, user can add it
as a shortcut in sidebar. However, sidebar provides bookmarks panel
as a default items. So, we should add bookmarks builtin item
instead of shortcut if it's removed.
This can apply also to all other builtin items.(talk, wallet).

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

npm run test brave_unit_tests -- --filter=*Sidebar*
See STR in the linked issue.

@simonhong simonhong self-assigned this Feb 17, 2022
@simonhong simonhong marked this pull request as ready for review February 17, 2022 02:52
@github-actions github-actions bot added rebase and removed rebase labels Feb 17, 2022
@bsclifton bsclifton changed the title Don't add as a separate shortcut when bulitin provide related item Don't add as a separate shortcut when built-in provide related item Feb 22, 2022
fix brave/brave-browser#21124

When bookmarks manager is loaded in active tab, user can add it
as a shortcut in sidebar. However, sidebar provides bookmarks panel
as a default items. So, we should add bookmarks builtin item
instead of shortcut if it's removed.
This can apply also to all other builtin items.(talk, wallet).
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified functionality (before and after this patch). Works great 😄👍

Thanks for the renaming; much easier to follow! Left one additional comment, but otherwise looks perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat adding built-in items to sidebar differently than other pages
2 participants