Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor database #2163

Closed
NejcZdovc opened this issue Nov 16, 2018 · 3 comments · Fixed by brave/brave-core#921
Closed

Refactor database #2163

NejcZdovc opened this issue Nov 16, 2018 · 3 comments · Fixed by brave/brave-core#921
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Currently our API is tightly connected to activity table. Because of that we need to do a lot of hacks to get data about publisher. We are also missing visits column in activity_info table.

We need to split this info simpler API.
@NejcZdovc NejcZdovc added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Nov 16, 2018
@NejcZdovc NejcZdovc self-assigned this Nov 16, 2018
@NejcZdovc NejcZdovc mentioned this issue Nov 16, 2018
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 16, 2018
@NejcZdovc
Refactor database
35031ee 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
NejcZdovc added a commit to brave/brave-core that referenced this issue Nov 20, 2018
@NejcZdovc
Refactor database
b86a018 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 5, 2018
@NejcZdovc
Refactor database
e1d2c00 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 20, 2018
@NejcZdovc
Refactor database
80e30ed 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
@NejcZdovc NejcZdovc mentioned this issue Dec 21, 2018
Closed
2 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Dec 28, 2018
@NejcZdovc
Refactor database
abaa324 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@NejcZdovc
Refactor database
7229bbb 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 14, 2019
@NejcZdovc
Refactor database
177b00a 
- removes category column
- adds visits column

Resolves brave/brave-browser#2163
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 16, 2019
@NejcZdovc
Fixes restore normalize
53c490b 
Resolves brave/brave-browser#2163
@NejcZdovc NejcZdovc mentioned this issue Jan 16, 2019
Merged
@NejcZdovc NejcZdovc mentioned this issue Jan 16, 2019
Merged
@btlechowski btlechowski modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 22, 2019
@LaurenWags
Copy link
Member

@NejcZdovc @rebron @kjozwiak is this issue in the correct milestone? Shouldn't it be in 0.61.x?

@NejcZdovc
Copy link
Contributor Author

@LaurenWags this was merge into 0.60 brave/brave-core#1356

This was referenced Feb 15, 2019
Closed
Closed
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Feb 20, 2019 •
edited by srirambv
Loading

Verified passed with

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Mac OS X
  • Verified general Rewards regression and flow over several builds, but most recently with the one above.

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 7

Verified general Rewards regression
Verified update flow

Verification passed on

Brave 0.60.44 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux

Verified rewards flow both general and upgrade

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Refactors database brave/brave-core
6 participants
@bbondy @rebron @NejcZdovc @srirambv @LaurenWags @btlechowski