Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmarks panel blank #21819

Closed
rebron opened this issue Mar 22, 2022 · 4 comments · Fixed by brave/brave-core#12707
Closed

Bookmarks panel blank #21819

rebron opened this issue Mar 22, 2022 · 4 comments · Fixed by brave/brave-core#12707
Assignees
@simonhong
Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes regression release-notes/exclude
Milestone
1.37.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022 •
edited by kjozwiak
Loading

Description

Bookmarks panel is blank, likely due to chromium 100.

Steps to Reproduce

  1. Update to 1.38.60 or higher with Chromium 100.x
  2. Open bookmarks sidebar panel.
  3. Notice the bookmarks panel is blank

Also see brave/brave-core#12707 (comment) for additional cases/checks.

Actual result:

screenshot_2022-03-22_141428

Expected result:

Screenshot 2022-03-22 142055

Reproduces how often:

Easily.

Brave version (brave://version info)

1.38.60 but specifically looks to be Chromium 100 related.

Version/Channel Information:

  • Can you reproduce this issue with the current release? soon
  • Can you reproduce this issue with the beta channel? soon
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@rebron rebron added OS/Desktop feature/sidebar Relating to Brave's Sidebar feature regression priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude labels Mar 22, 2022
@simonhong simonhong mentioned this issue Mar 22, 2022
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Mar 23, 2022
@simonhong
Fixed sidebar bookmarks panel was empty
40e7c04 
fix brave/brave-browser#21819

Applied upstream changes

Author:     dpapad <dpapad@chromium.org>
AuthorDate: 2022-01-06 19:24:20 +0000
Commit:     Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
CommitDate: 2022-01-06 19:24:20 +0000

SidePanel: Stop importing pre-JS modules Mojo bindings, not needed.

Bug: 1179821
Change-Id: I0a72614422db9bb398bd5eb48a9b7f1c79e33f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370342
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#956201}
simonhong added a commit to brave/brave-core that referenced this issue Mar 23, 2022
@simonhong
Fixed sidebar bookmarks panel was empty
90f3258 
fix brave/brave-browser#21819

Applied upstream changes

Author:     dpapad <dpapad@chromium.org>
AuthorDate: 2022-01-06 19:24:20 +0000
Commit:     Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
CommitDate: 2022-01-06 19:24:20 +0000

SidePanel: Stop importing pre-JS modules Mojo bindings, not needed.

Bug: 1179821
Change-Id: I0a72614422db9bb398bd5eb48a9b7f1c79e33f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370342
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#956201}
@simonhong simonhong mentioned this issue Mar 23, 2022
Merged
7 tasks
@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 23, 2022
@kjozwiak
Copy link
Member

Above will require 1.37.104 or higher for 1.37.x verification.

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.37.105 Chromium: 100.0.4896.46 (Official Build) (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 10 Version 21H2 (Build 19044.1586)

@stephendonner
Copy link

Verified PASSED using

Brave 1.37.105 Chromium: 100.0.4896.46 (Official Build) (x86_64)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS macOS Version 11.6.5 (Build 20G527)
example example
Screen Shot 2022-03-26 at 11 47 48 PM Screen Shot 2022-03-26 at 11 48 58 PM

@btlechowski
Copy link

Verification passed on

Brave 1.37.107 Chromium: 100.0.4896.46 (Official Build) (64-bit)
Revision 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed sidebar bookmarks panel was empty after cr100 brave/brave-core
7 participants
@stephendonner @kjozwiak @emerick @rebron @simonhong @btlechowski @GeetaSarvadnya