Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sidebar bookmarks panel was empty (uplift to 1.37.x) #12708

Merged
merged 1 commit into from
Mar 23, 2022
Merged

Fixed sidebar bookmarks panel was empty (uplift to 1.37.x) #12708

merged 1 commit into from
Mar 23, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 23, 2022 •
edited by kjozwiak
Loading

Uplift of #12707
Resolves brave/brave-browser#21819

NOTE:
#12707 is not merged yet. Just prepared in advance.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong
Fixed sidebar bookmarks panel was empty
90f3258 
fix brave/brave-browser#21819

Applied upstream changes

Author:     dpapad <dpapad@chromium.org>
AuthorDate: 2022-01-06 19:24:20 +0000
Commit:     Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
CommitDate: 2022-01-06 19:24:20 +0000

SidePanel: Stop importing pre-JS modules Mojo bindings, not needed.

Bug: 1179821
Change-Id: I0a72614422db9bb398bd5eb48a9b7f1c79e33f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370342
Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/main@{#956201}
@simonhong simonhong requested a review from a team March 23, 2022 00:18
@simonhong simonhong self-assigned this Mar 23, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Mar 23, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong simonhong changed the title Fixed sidebar bookmarks panel was empty Fixed sidebar bookmarks panel was empty (uplift to 1.37.x) Mar 23, 2022
@kjozwiak kjozwiak added this to the 1.37.x - Beta milestone Mar 23, 2022
@kjozwiak
Copy link
Member

Waiting for 1.38.66 or higher to become available via https://github.com/brave/brave-browser/releases on either Win x64 or macOS x64. Currently https://github.com/brave/brave-browser/releases/tag/v1.38.66 only has macOS arm x64 available.

kjozwiak
kjozwiak approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.37.x approved 👍 QA has verified the PR on Nightly as per #12707 (comment).

@kjozwiak kjozwiak merged commit bf264a8 into 1.37.x Mar 23, 2022
@kjozwiak kjozwiak deleted the sidebar_bookmarks_regression_1.37.x branch March 23, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@simonhong @brave-builds @kjozwiak