Changes to sync codephrase

[AlexeyBarabash]

See details at https://github.com/brave/internal/issues/869, Android and Desktop part

[iccub]

iOS issue to track here
brave/brave-ios#5362

[stephendonner]

Verification PASSED using

Brave	1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	macOS Version 11.6.7 (Build 20G630)

NOTE: Android's tests here were run on June 29th; original desktop tests were run on June 21st, hence the desktop/Android date discrepancies in the notes.

Case I: Old sync words are accepted before sync words sunset date - PASSED

1. Created a new sync chain on 1.40.105 desktop browser (24 words)
2. Connected 1.41.74 desktop browser to the chain
3. Connected 1.41.84 Android browser to the chain via code words
4. Connected 1.41.84 Android browser to the chain va QR code

example	example	example	example	example

Case II. Old sync words are NOT accepted after sync words sunset date - PASSED

1. Create chain on 1.39.122 desktop browser (24 words)
2. Modify current date on the client (2nd) desktop to August 2, 2022
3. Try to connect 1.41.x desktop browser to the chain - it should say This code was generated by a deprecated version of Brave, please upgrade your other device first.
4. Try to connect 1.41.x Android to the chain via code words; it should say `Sync could not be setup [This code was generated by a deprecated version of Brave, please upgrade your other device first]

example	example	example	example	example

Case III. Normal flow between new (v2) versions - PASSED

1. Created sync chain on 1.41.59 desktop version (25 words)
2. Connected 1.41.x desktop to chain via code words
3. Connected 1.41.x Android to chain via code words

Sync chain	new client joined	Synch chain updated	Android client

Case IV. Expired error - PASSED

1. Create sync chain on1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days forward (June 23, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code has expired. Please generate a new one on your other device and try again.
4. Adjust time on Android device 2 days forward (July 1, 2022 in my case)
5. Connected 1.41.x Android device to chain via code words - it said This code has expired. Please generate a new one on your other device and try again.

example	example	example	example	example	example	example

Case V. Too-far-in-the-future codes - PASSED

1. Create sync chain on 1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days backwards (June 19, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code is invalid. Please check that the time and timezone are set correctly on your device.
4. Adjust time on Android device 2 days backwards (June 27, 2022) in my case)
5. Connect 1.41.x Android browser to Sync chain via code words; it said This code is invalid. Please check that the time and timezone are set correctly on your device.

example	example	example	example	example	example

Case VI. General errors for incorrect codes - PASSED

• Try to enter the sync chain on 1.41.x desktop with words AAA BBB CCC, etc.- it should say This code is invalid

AAA BBB CCC	AAA -> YYYY

Also made sure we got errors using 24 25 and 26word-count entries.

24-count error	25-count error	26-count error

[MadhaviSeelam]

Verification PASSED using

Brave | 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 11 Version 21H2 (Build 22000.739)

Filed #23772

Case I: Old sync words are accepted before sync words sunset date - PASSED

1. Created a new sync chain on 1.40.105 desktop browser (24 words)
2. Connected 1.41.74 desktop browser to the chain - it should connect - Confirmed
3. Connect new Android browser to the chain with words - it should connect. - Confirmed
4. Connect new Android browser to the chain with QR - it also should connect. - Confirmed

ex1	ex2	ex3	ex4	ex5	ex6

Case II. Old sync words are NOT accepted after sync words sunset date- PASSED

1. Create chain on 1.40.105 desktop browser (24 words)
2. Modify current date on the client (2nd) desktop to August 2, 2022
3. Try to connect 1.41.x desktop browser to the chain - it should say This code was generated by a deprecated version of Brave, please upgrade your other device first. - Confirmed
4. Modify current date on the desktop to 2nd of August;
5. Try to connect new Android browser to the chain with words - it also should say - Confirmed
   This code was generated by a deprecated version of Brave, please upgrade your other device first

Ex1	Ex2	Ex3	error message	android

Case III. Normal flow between new (v2) versions- PASSED

1. Create sync chain on 1.41.59 desktop version (25 words)
2. Connect new browser desktop to chain via words - it should succeed - Confirmed
3. Connect new browser Android to chain via words - it also should succeed - Confirmed

Ex1	Ex2	Ex3	Ex4	Ex5	Ex6

Case IV. Expired error - PASSED

1. Create sync chain on1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days forward (June 23, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code has expired. Please generate a new one on your other device and try again.- Confirmed
4. Adjust time on Android device 2 days forward
5. Connect new browser Android to chain via words - it also should say
   This code has expired. Please generate a new one on your other device and try again.- Confirmed

Ex1	Ex2	Ex3	Android1	Android2

Case V. Too-far-in-the-future codes - PASSED

1. Create sync chain on 1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days backwards (June 19, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code is invalid. Please check that the time and timezone are set correctly on your device. - Confirmed
4. Adjust time on 2nd Android device 2 days backwards;
5. Connect new browser Android to chain via words - it also should also say
   This code is invalid. Please check that the time and timezone are set correctly on your device. - Confirmed

Ex1	Ex2	Ex3	Ex4	Ex5	Ex6

Case VI. General errors for incorrect codes - PASSED

1. Try to enter the sync chain on 1.41.x desktop with words AAA BBB CCC, etc.- it should say This code is invalid Confirmed
2. Try to enter the sync chain on new Android with words AAA BBB CCC - it should also say
3. Wrong sync code Confirmed
4. Try to enter the sync chain on 1.41.x desktop with 24 words - it should say This code is invalid
5. Try to enter the sync chain on 1.41.x desktop with 25 words - it should say This code is invalid
6. Try to enter the sync chain on 1.41.x desktop with 26 words - it should say This code is invalid

Ex1	Ex2	android	24words-error	25words-error	26words-error

[stephendonner]

Verification PASSED using

Brave	1.41.80 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision	a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS	Linux

Case I: Old sync words are accepted before sync words sunset date - PASSED

1. Created a new sync chain on 1.40.105 desktop browser (24 words)
2. Connected 1.41.74 desktop browser to the chain

example	example	example	example

Case II. Old sync words are NOT accepted after sync words sunset date - PASSED

1. Create chain on 1.39.122 desktop browser (24 words)
2. Modify current date on the client (2nd) desktop to August 2, 2022
3. Try to connect 1.41.x desktop browser to the chain - it should say This code was generated by a deprecated version of Brave, please upgrade your other device first.

example	example	example	example

Case III. Normal flow between new (v2) versions - PASSED

1. Create sync chain on 1.41.59 desktop version (25 words)
2. Connect new browser desktop to chain via words - it should succeed

Sync chain	new client joined	Sync chain updated

Case IV. Expired error - PASSED

1. Create sync chain on1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days forward (June 29, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code has expired. Please generate a new one on your other device and try again.

example	example	example

Case V. Too-far-in-the-future codes - PASSED

1. Create sync chain on 1.41.x desktop version (25 words)
2. Adjust time on 2nd desktop device 2 days backwards (June 25, 2022 in my case)
3. Connect new browser desktop to chain via words - it should say This code is invalid. Please check that the time and timezone are set correctly on your device.

example	example	example	example

Case VI. General errors for incorrect codes - PASSED

• Try to enter the sync chain on 1.41.x desktop with words AAA BBB CCC, etc.- it should say This code is invalid

AAA BBB CCC	AAA -> YYYY

Also made sure we got errors using 24 25 and 26word-count entries.

24-count error	25-count error	26-count error

[srirambv]

Verification passed on Oppo Reno 5(Android 12) /Samsung Tab A (Android 10) running 1.41.94 x64 build

Case 1: Sync between devices running v2 version with cross time zones

• Verified able to sync devices running Sync v2
• Verified both devices are listed correctly
• Verified switching time zones on the devices and resetting Sync and creating a new one works fine

Sync v2 code	Device 1 (Source)	Device 2

Case 2: Old sync words are accepted before sync words sunset date

• Verified creating Sync chain on Device A using 1.40.101 which uses 24 sync words works fine
• Verified able to connect Device B to Sync chain using QR Code
• Verified able to connect Device C to Sync chain using code words
• Verified Device B adds the 25th word to the list which is time based and not sync'd back to Device A

Device A (24 words)	Device B (25 Words )

Case 3: Old sync words are NOT accepted after sync words sunset date (Partial Pass)

• Verified creating Sync chain on Device A using 1.39.123 which uses 24 sync words works fine
• Verified when trying to enter Sync code words on Device B running 1.41.94 throws error message Sync could not be setup [This code was generated by a deprecated version of Brave, please upgrade your other device first]
• Encountered #23936 when trying add sync chain via QR code

Device A (24 words)	Device B (25 Words )

Case 4: Case for expired error

• Verified able to create sync chain with 25 words on Device A
• Move Device B dates ahead by 2 days and try to sync with QR Code, shows error This code has expired. Please generate a new one on your other device and try again

QR Code	Code Words

Case 5: Case for too far in the future error

• Verified able to create sync chain with 25 words on Device A
• Move Device B dates behind by 2 days and try to sync with QR Code, shows error This code is invalid. Please check that the time and timezone are set correctly on your device.
• Encountered #23948

Case 6: Case for general error of wrong code

• Verified entering AAA BBB CCC says Wrong sync code