Time-limited sync words #12300

AlexeyBarabash · 2022-02-16T16:13:21Z

This PR introduces time-limited sync code words. The browser accept the old sync code till the grace period, currently Mon, 1 Aug 2022 - but may be changed. Changes are done for Desktop and Android.

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I. Old sync words are accepted before sync words sunset date

Create chain on old desktop browser, 24 words;
Connect new desktop browser to the chain - it should connect;
Connect new Android browser to the chain with words - it should connect.
Connect new Android browser to the chain with QR - it also should connect.

II. Old sync words are not accepted after sync words sunset date

Create chain on old desktop browser, 24 words;
magic room blind room mimic suspect interest fiber above south end injury quality wonder maid book syrup brush right alter fit weasel buffalo stove
Modify current date on the desktop to 2nd of August;
Try to connect new desktop browser to the chain - it should say
This code was generated by a deprecated version of Brave, please upgrade your other device first;
Modify current date on the Android to 2nd of August;
Try to connect new Android browser to the chain with words - it also should say
This code was generated by a deprecated version of Brave, please upgrade your other device first;

III. Normal flow between new versions

Create sync chain on new desktop version, 25 words.
Connect new browser desktop to chain via words - it should succeed;
Connect new browser Android to chain via words - it also should succeed;

IV. Case for expired error

Create sync chain on new desktop version, 25 words.
Adjust time on 2nd desktop device 2 days forward;
Connect new browser desktop to chain via words - it should say
This code has expired. Please generate a new one on your other device and try again;
Adjust time on Android device 2 days forward;
Connect new browser Android to chain via words - it also should say
This code has expired. Please generate a new one on your other device and try again;

V. Case for too far in the future error

Create sync chain on new desktop version, 25 words.
Adjust time on 2nd desktop device 2 days backwards;
Connect new browser desktop to chain via words - it should say
This code is invalid. Please check that the time and timezone are set correctly on your device;
Adjust time on 2nd Android device 2 days backwards;
Connect new browser Android to chain via words - it also should also say
This code is invalid. Please check that the time and timezone are set correctly on your device.

VI. Case for general error of wrong code

Try to enter the sync chain on new desktop with words AAA BBB CCC - it should say
This code is invalid
Try to enter the sync chain on new Android with words AAA BBB CCC - it should also say
Wrong sync code

Fixes brave/brave-browser#22242

… without 25th word of time code

AlexeyBarabash · 2022-05-25T21:00:30Z

rebased again, as work on iOS needs this to be in master to proceed

- updated comments - removed forgotten include - used base::StrCat - redone TimeLimitedWords::Validate => TimeLimitedWords::Parse to avoid using of output string* parameter - fixed ret.pure_words initialization - removed forgotten log - from js and html changes combined variables isInvalidSyncCode and syncCodeValidationResult into single syncCodeValidationError Adjusted words epoch and v1 sunset dates - epoch to Tue, 10 May 2022 - sunset to Mon, 1 Aug 2022

AlexeyBarabash · 2022-05-26T08:24:01Z

Updated sunset date for words v1 to Mon, 1 Aug 2022, right after current milestone 1.41.x planned date July 12, 2022

Time-limited sync words

stephendonner · 2022-06-13T21:02:53Z

Verification `PASSED` using

Brave	1.41.59 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
Revision	de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS	macOS Version 12.5 (Build 21G5037d)

&

Brave	1.39.122 Chromium: 102.0.5005.115 (Official Build) (x86_64)
Revision	174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS	macOS Version 12.5 (Build 21G5037d)

Case I: Old sync words are accepted before sync words sunset date - PASSED

Created a new sync chain on 1.39.122 desktop browser (24 words)
Connected 1.41.59 desktop browser to the chain - it should connect

example	example	example	example

Case II. Old sync words are NOT accepted after sync words sunset date - PASSED

Create chain on 1.39.122 desktop browser (24 words)
Modify current date on the desktop to August 2, 2022
Try to connect 1.41.59 desktop browser to the chain - it should say This code was generated by a deprecated version of Brave, please upgrade your other device first.

example	example	example	example	example

Case III. Normal flow between new (`v2`) versions - PASSED

Create sync chain on 1.41.59 desktop version (25 words)
Connect new browser desktop to chain via words - it should succeed

Sync chain	new client joined	Synch chain updated

Case IV. Expired error - PASSED

Create sync chain on1.41.59 desktop version (25 words)
Adjust time on 2nd desktop device 2 days forward (June 15, 2022 in my case)
Connect new browser desktop to chain via words - it should say This code has expired. Please generate a new one on your other device and try again.

example	example	example	example

Case V. Too-far-in-the-future codes - PASSED

Create sync chain on 1.41.59 desktop version (25 words)
Adjust time on 2nd desktop device 2 days backwards (June 11, 2022 in my case)
Connect new browser desktop to chain via words - it should say This code is invalid. Please check that the time and timezone are set correctly on your device.

example	example	example	example	example

Case VI. General errors for incorrect codes - PASSED

Try to enter the sync chain on 1.41.59 desktop with words AAA BBB CCC, etc.- it should say This code is invalid

`AAA BBB CCC`	`AAA -> YYYY`

Also made sure we got errors using 24 25 and 26word-count entries.

`24-count error`	`25-count error`	`26-count error`

AlexeyBarabash added feature/sync CI/skip Do not run CI builds (except noplatform) labels Feb 16, 2022

github-actions bot assigned AlexeyBarabash Feb 16, 2022

github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Feb 16, 2022

AlexeyBarabash force-pushed the sync_timelimit_bip branch 3 times, most recently from 1eafae6 to c9fb75d Compare February 18, 2022 13:28

AlexeyBarabash force-pushed the sync_timelimit_bip branch 4 times, most recently from 71d49c0 to 1948418 Compare March 30, 2022 16:25

AlexeyBarabash force-pushed the sync_timelimit_bip branch 5 times, most recently from f29ddba to c865eee Compare April 11, 2022 18:35

AlexeyBarabash force-pushed the sync_timelimit_bip branch 2 times, most recently from 61b8591 to bd51e9f Compare April 12, 2022 17:21

AlexeyBarabash marked this pull request as ready for review April 12, 2022 18:06

AlexeyBarabash requested a review from a team as a code owner April 12, 2022 18:06

AlexeyBarabash requested review from mkarolin, petemill, darkdh and fmarier April 12, 2022 18:07

github-actions bot added the rebase label Apr 12, 2022

AlexeyBarabash force-pushed the sync_timelimit_bip branch from bd51e9f to 0e675db Compare April 12, 2022 18:07

github-actions bot removed the rebase label Apr 12, 2022

AlexeyBarabash added this to the 1.39.x - Nightly milestone Apr 13, 2022

AlexeyBarabash removed the CI/skip Do not run CI builds (except noplatform) label Apr 14, 2022

AlexeyBarabash force-pushed the sync_timelimit_bip branch from 0e675db to 31b33f6 Compare April 14, 2022 14:04

AlexeyBarabash added 10 commits May 25, 2022 23:27

Removed forgotten include

8f1e1d4

Time-limited sync words class and tests

9fe2d6d

Fixes brave/brave-browser#22242

Desktop uses sync words v2

544947a

Desktop setup sync error messages

7aab3d0

Android connects to sync through time limited bip words

00c7598

Brave sync settings page getPureSyncCode method to receive sync words…

b2ee995

… without 25th word of time code

Fixed sync QR code generation to use pure sync words

a35d312

Adjusted kWordsv1SunsetDate date

f0092bb

Desktop sync setup shows different error messages

6726848

Introduced TimeLimitedWords::GetWordsV2Epoch() date

c57800d

AlexeyBarabash force-pushed the sync_timelimit_bip branch from bf67782 to 074d50e Compare May 25, 2022 20:59

AlexeyBarabash modified the milestones: 1.40.x - Beta, 1.41.x - Nightly May 25, 2022

AlexeyBarabash force-pushed the sync_timelimit_bip branch from 074d50e to a66b2d5 Compare May 26, 2022 08:20

AlexeyBarabash merged commit 2c94e60 into master May 26, 2022

AlexeyBarabash deleted the sync_timelimit_bip branch May 26, 2022 10:23

Brandon-T mentioned this pull request May 27, 2022

[1.41] Fix #5362: Update Sync Phase v2 (Time-Limited Sync Codes) brave/brave-ios#5400

Merged

7 tasks

AlexeyBarabash added a commit that referenced this pull request May 30, 2022

Uplift of #12300 (squashed) to beta

70554b6

AlexeyBarabash mentioned this pull request May 30, 2022

Time-limited sync words (uplift to 1.40.x) #13533

Closed

7 tasks

AlexeyBarabash added a commit that referenced this pull request May 30, 2022

Merge pull request #12300 from brave/sync_timelimit_bip

b574631

Time-limited sync words

AlexeyBarabash mentioned this pull request May 30, 2022

Time-limited sync words (uplift to 1.39.x) #13536

Closed

7 tasks

This was referenced Jun 2, 2022

[iOS] - Sync Phase v2 TimeLimited Uplift - 1.40.x #13513

Closed

Sync Nightly code causes failure on Beta and Stable brave/brave-browser#23206

Closed

AlexeyBarabash mentioned this pull request Jun 13, 2022

Unable to initiate the sync chain between nightly and other channels brave/brave-browser#23428

Closed

srirambv mentioned this pull request Jul 8, 2022

Error message is different for QR Code and Code words brave/brave-browser#23948

Closed

Uni-verse mentioned this pull request Jul 19, 2022

Changes to sync codephrase brave/brave-ios#5362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Time-limited sync words #12300

Time-limited sync words #12300

AlexeyBarabash commented Feb 16, 2022 •

edited

Loading

AlexeyBarabash commented May 25, 2022

AlexeyBarabash commented May 26, 2022

stephendonner commented Jun 13, 2022 •

edited

Loading

Time-limited sync words #12300

Time-limited sync words #12300

Conversation

AlexeyBarabash commented Feb 16, 2022 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

AlexeyBarabash commented May 25, 2022

AlexeyBarabash commented May 26, 2022

stephendonner commented Jun 13, 2022 • edited Loading

Verification PASSED using

Case I: Old sync words are accepted before sync words sunset date - PASSED

Case II. Old sync words are NOT accepted after sync words sunset date - PASSED

Case III. Normal flow between new (v2) versions - PASSED

Case IV. Expired error - PASSED

Case V. Too-far-in-the-future codes - PASSED

Case VI. General errors for incorrect codes - PASSED

AlexeyBarabash commented Feb 16, 2022 •

edited

Loading

stephendonner commented Jun 13, 2022 •

edited

Loading

Verification `PASSED` using

Case III. Normal flow between new (`v2`) versions - PASSED