Not all of 5000 bookmarks are sent to sync sometimes

[AlexeyBarabash]

Description

Not all of 5000 bookmarks are sent to sync sometimes

Steps to Reproduce

1. Initialize sync on device A
2. Connect to sync device B
3. On the device A do import of 5000 bookmarks
4. When bookmarks will start to appear on the device B, open brave://bookmarks on device A, expand and scroll as far as you can

Actual result:

Not all bookmarks are sent from A to B

Expected result:

All bookmarks are sent from A to B

Reproduces how often:

from time to time

Brave version (brave://version info)

Brave | 0.59.1 Chromium: 71.0.3578.53 (Developer Build) (64-bit)
Revision | 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?
  Not sure, reproducible on nightly.

[AlexeyBarabash]

Met this issue again when tried to see #2367 .

[AlexeyBarabash]

Tried locally with brave/sync#267 by @samartnik , issue gone, plus syncing was much faster.

[AlexeyBarabash]

Fixed with #2811 .

[srirambv]

@AlexeyBarabash could you add the test steps to the PR/issue for verification? From the original issue steps you have mentioned that not all bookmarks are sent. When I try to sync 5k bookmarks, the folder structure is sent across to device 2 and only the last nested folder has the bookmarks inside it. The higher nested bookmark folders start receiving chunks in successive fetch call. Is this expected or need to verify something else?

[AlexeyBarabash]

@srirambv
Yes, this is expected.

Here are another STR, more precise:

1. Initialize sync on device A
2. Connect to sync device B
3. On the device A do import of bookmarks_big_folder_.html file (3956 bookmarks)
4. Expected: After sync completes ensure device B also has 3956 bookmarks in BigFolder bookmarks folder.

bookmarks_big_folder_.html.zip

[srirambv]

Verification passed on

Brave	0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Linux

Verification passed on

Brave	0.59.18 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Windows

• Verified the STR from Not all of 5000 bookmarks are sent to sync sometimes #2283 (comment)
  

Verified passed on

Brave	0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

• Verified steps from Not all of 5000 bookmarks are sent to sync sometimes #2283 (comment)