This repository has been archived by the owner on Jul 31, 2020. It is now read-only.
Fixed receiving objects in chunk #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested locally with brave-core. This PR fixes brave/brave-browser#2283 and also does huge speedup for syncing of large folders. |
SergeyZhukovsky
requested review from
SergeyZhukovsky,
darkdh and
diracdeltas
darkdh
reviewed
Dec 28, 2018
client/requestUtil.js
Outdated
| const prefix = `${this.apiVersion}/${this.userId}/${category}` | ||
| let options = { | ||
| MaxKeys: maxRecords || 1000, | ||
| Bucket: this.bucket, | ||
| Prefix: prefix | ||
| } | ||
| if (nextContinuationToken != '') { |
lib/s3Helper.js
Outdated
| @@ -221,7 +221,8 @@ module.exports.listObjects = function (s3, options, limitResponse) { | |||
| } else { | |||
| resolve({ | |||
| contents: data.Contents, | |||
| isTruncated: data.IsTruncated | |||
| isTruncated: data.IsTruncated, | |||
| nextContinuationToken : data.NextContinuationToken | |||
lib/s3Helper.js
Outdated
| @@ -230,7 +231,8 @@ module.exports.listObjects = function (s3, options, limitResponse) { | |||
| if (error) { reject(error) } | |||
| resolve({ | |||
| contents: data, | |||
| isTruncated: false | |||
| isTruncated: false, | |||
| nextContinuationToken : '' | |||
|
not sure why browser test and coverage fails on CI. works good on my local env |
Closed
SergeyZhukovsky
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Looks good to me. @darkdh @diracdeltas we decided to merge it to unblock QA from testing desktop and Android and create an issue to investigate the travis problems. All tests are passed locally and EC2 instance, they don't through travis for some reason.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes https://github.com/brave/browser-android-tabs/issues/925