Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always Show Full URLs should be Always show full URLs in brave://settings/appearance #23179

Closed
stephendonner opened this issue Jun 1, 2022 · 5 comments · Fixed by brave/brave-core#14309

Comments

@stephendonner
Copy link

Description

Always Show Full URLs should be Always show full URLs in brave://settings/appearance

Steps to Reproduce

  1. install 1.41.21
  2. launch Brave
  3. open brave://settings/appearance
  4. read the Always Show Full URLs pref description, and compare to Always show bookmarks on new tab page (sic)

Actual result:

Always Show Full URLs

Screen Shot 2022-05-31 at 10 51 54 PM

Expected result:

Always show full URLs

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.21 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.5 (Build 21G5027d)

cc @rmcfadden3

@Tonev
Copy link
Contributor

Tonev commented Jun 4, 2022

Hey, @stephendonner 👋

Let's give it a go brave/brave-core#13612 🤞

@stephendonner
Copy link
Author

stephendonner commented Jun 6, 2022

Thanks for taking a stab at this, @Tonev! Looking at your PR, it appears it's for this context-menu option, rather than brave://settings/appearance (or is it used in both?)

Screen Shot 2022-06-06 at 12 47 04 PM

on macOS, I believe we want to keep Title Case for this string in the context menu.

@mkarolin or @emerick mind helping with this one? Sorry for the ping!

@fallaciousreasoning
Copy link

Also fixes #16939

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.43.56 Chromium: 104.0.5112.81 (Official Build) dev (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

Confirmed it now reads Always show full URLs

Screen Shot 2022-08-03 at 9 51 10 AM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 9, 2022

Verification PASSED using

Brave | 1.43.91 Chromium: 105.0.5195.102 (Official Build) (64-bit)
-- | --
Revision | 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS | Windows 11 Version 21H2 (Build 22000.856)

Couldn't reproduce the issue in 1.41.21. Always show full URLs shown as expected in brave://settings/appearance in both 1.41. 21 and 1.43.91

1.41.21 1.43.91
1.41.21 1.41.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants