Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new string resource for setting page #14309

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Jul 23, 2022

We used same string resource for context menus. But context menu's
strings can be 'title case' when it's for Mac. As we don't use
title case for settings page, we should use new string.

Resolves brave/brave-browser#23179

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Manual:

  • Go to "brave://settings/appearance" and check if string is "Always show full URLs" which is not in title case.

We used same string resource for context menus. But context menu's
strings can be 'title case' when it's for Mac. As we don't use
title case for settings page, we should use new string.
@sangwoo108 sangwoo108 requested a review from emerick July 23, 2022 08:42
@sangwoo108 sangwoo108 marked this pull request as ready for review July 23, 2022 08:43
@sangwoo108
Copy link
Contributor Author

Hi, @emerick . Could you take a look at this? Thanks!

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangwoo108 sangwoo108 merged commit 4e3ac28 into master Jul 25, 2022
@sangwoo108 sangwoo108 deleted the sko/string-setting branch July 25, 2022 15:05
@github-actions github-actions bot added this to the 1.43.x - Nightly milestone Jul 25, 2022
@sangwoo108
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always Show Full URLs should be Always show full URLs in brave://settings/appearance
2 participants