Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip text for Brave Search omnibox promo close widget is too geeky #23607

Closed
stephendonner opened this issue Jun 22, 2022 · 4 comments · Fixed by brave/brave-core#13914
Closed
Assignees

Comments

@stephendonner
Copy link

Description

Tooltip text for Brave Search omnibox promo close widget is too geeky

Steps to Reproduce

  1. installed 1.41.76
  2. launched Brave using --enable-features=BraveSearchOmniboxButton command-line switch
  3. set Search engine used in the address bar to DuckDuckGo
  4. typed brunch
  5. hovered over the X widget
  6. read the tooltip text

Actual result:

Dismiss brave search conversion

Screen Shot 2022-06-22 at 9 32 41 AM

Expected result:

Something like Close Brave Search promotion (@rmcfadden3 help wordsmithing?)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.76 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

cc @rmcfadden3 @aguscruiz @jenn-rhim

@stephendonner
Copy link
Author

We can probably do this in one shot; this also affects the tooltip for the banner:

  1. installed 1.41.76
  2. launch Brave using --enable-features=BraveSearchOmniboxBanner command-line switch
  3. set Search engine used in the address bar to Ecosia
  4. typed brunch and confirmed Try Brave Search
  5. hovered over Dismiss
  6. checked the tooltip

Tooltip reads Dismiss brave search conversion.

Screen Shot 2022-06-22 at 9 51 57 AM

@rebron
Copy link
Collaborator

rebron commented Jun 22, 2022

@rmcfadden3 Dismiss here will function more like a "Don't show this again"

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 22, 2022
@rmcfadden3
Copy link

@rebron & @stephendonner — I'm good with the "Don't show this again" text. It makes sense here, and also saves us on localization.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.42.21 Chromium: 103.0.5060.53 (Official Build) nightly (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 12.5 (Build 21G5046c)

Followed my original steps to reproduce, above.

Confirmed the tooltip text now reads Don't show this again

button banner
Screen Shot 2022-06-23 at 12 30 57 PM Screen Shot 2022-06-23 at 12 38 33 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants