-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3A traffic isn't sent to the p3a-json.brave.com endpoint #23754
Comments
@rillian Looks like P2A metrics are also affected by this issue. #22079 (comment). @brave/legacy_qa Please verify the P2A metrics as well once the PR is up (follow the test plan from brave/brave-core#13538) |
This is causing issues with delayed report submission. Revert the change to work around brave/brave-browser#23754
Prevously, we marked P3A reports as sent when the protobuf format message was delivered successfully. When we started sending only json format messages, this led to messages being queued for retrial endlessly, greatly delaying submission. Move the completetion callback to the new json log uploader. Now that we're sending json-format messages to both P3A and P2A endpoints, we can consider that the completion of the task and only send protobuf messages incidentally. Fixes brave/brave-browser#23754
This is causing issues with delayed report submission. Revert the change to work around brave/brave-browser#23754
Closing as brave/brave-core#14015 was merged into |
Verification PASSED on
Basically we ensured P3A and P2A works as it works in
|
Description
Found while testing #23147
P3A traffic isn't sent to the
p3a-json.brave.com
endpoint, This is a regression issue after removing p3a.brave.com via #23147Steps to Reproduce
1.41.82
1.41.81
p3a-json.brave.com
endpoint, I could see only one metric data listedActual result:
P3A traffic isn't sent to the p3a-json.brave.com endpoint
Expected result:
All the metrics from
brave://local-state
should be shown in thep3a-json.brave.com
endpointReproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/qa-team @rillian @porteron @mattmcalister @rebron
The issue is reproduced by @rillian and @stephendonner, thanks both!
The text was updated successfully, but these errors were encountered: