Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert stopping P3A protobuf submission for 1.41 #14015

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jun 29, 2022

Revert broken submission disable code which caused submission delays. This is the safest fix for beta. It just postpones shutting off protobuf submission until the next release.

Works around brave/brave-browser#23754

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@rillian rillian added this to the 1.41.x - Beta milestone Jun 29, 2022
@rillian rillian requested a review from a team as a code owner June 29, 2022 23:34
@rillian rillian self-assigned this Jun 29, 2022
This is causing issues with delayed report submission. Revert the
change to work around brave/brave-browser#23754
@rillian rillian force-pushed the p3a-protobuf-revert-1.41 branch from 10a3729 to 5e6e73d Compare June 30, 2022 15:44
@rillian
Copy link
Contributor Author

rillian commented Jun 30, 2022

NB reviewers: windows-x86 ci job keeps timing out. I don't think it's related to this patch. Other pipelines are green.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.41.x approved 👍 As per the discussion via Slack, we won't be able to verify this one until it's uplifted into 1.41.x as we're going directly into 1.41.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants