Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not prefetch NTP ad on browser start #23822

Closed
aseren opened this issue Jul 1, 2022 · 1 comment · Fixed by brave/brave-core#14029
Closed

Do not prefetch NTP ad on browser start #23822

aseren opened this issue Jul 1, 2022 · 1 comment · Fixed by brave/brave-core#14029
Assignees
@aseren
Labels
feature/ads OS/Desktop QA/No release-notes/exclude
Milestone
1.42.x - Release

Comments

@aseren
Copy link

aseren commented Jul 1, 2022

The problem is that prefetched NTP ad could be from an old catalog which was fetched during previous browser start.
@aseren aseren self-assigned this Jul 1, 2022
@aseren aseren mentioned this issue Jul 1, 2022
Merged
25 tasks
aseren added a commit to brave/brave-core that referenced this issue Jul 4, 2022
@aseren
Do not prefetch NTP ad on browser start
56c350e 
fix brave/brave-browser#23822
@brave-builds brave-builds added this to the 1.42.x - Nightly milestone Jul 4, 2022
@aseren
Copy link
Author

aseren commented Jul 4, 2022

Functionality should be tested here: #14015

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
feature/ads OS/Desktop QA/No release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Do not prefetch NTP ad on browser start brave/brave-core
2 participants
@brave-builds @aseren