Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prefetch NTP ad on browser start #14029

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Do not prefetch NTP ad on browser start #14029

merged 1 commit into from
Jul 4, 2022

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jul 1, 2022

Removed prefetching of NTP ad on browser start, as it could trigger an ad from an old catalog.

Resolves brave/brave-browser#23822

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Functionality should be tested here: brave/brave-browser#14015

@aseren aseren requested a review from a team as a code owner July 1, 2022 13:32
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren merged commit cb2dc0f into master Jul 4, 2022
@aseren aseren deleted the issues/23822 branch July 4, 2022 19:38
@github-actions github-actions bot added this to the 1.42.x - Nightly milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not prefetch NTP ad on browser start
2 participants