Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow up #23652] Desktop site is not enabled during upgrade if Desktop Mode was set to enable #23871

Closed
srirambv opened this issue Jul 5, 2022 · 2 comments · Fixed by brave/brave-core#14053
Assignees
Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Description

As per test plan in #23652 (comment), Desktop Site should be enabled regardless of its state post upgrade as long as Desktop Mode was set to ON before upgrade. This is currently not working as intended

Steps to reproduce

  1. Install 1.41.65 nightly build which has duplicate desktop entries under site settings
  2. Set Desktop Mode to ON and leave Desktop Site to OFF (default)
  3. Upgrade to 1.42.52
  4. Desktop Mode is removed as expected, but Desktop Site remains OFF when it should have been set to ON

Actual result

Desktop.Site.post.upgrade.mp4

Expected result

Should set Desktop Site to enabled as per test plan

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.42.52

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @samartnik

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

The above will require 1.41.94 or higher for 1.41.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Jul 7, 2022

Verified as part of #23652 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants