Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Desktop Mode option as it is a duplicate now #23652

Closed
samartnik opened this issue Jun 23, 2022 · 4 comments · Fixed by brave/brave-core#13953
Closed

Remove Desktop Mode option as it is a duplicate now #23652

samartnik opened this issue Jun 23, 2022 · 4 comments · Fixed by brave/brave-core#13953

Comments

@samartnik
Copy link
Contributor

Description

In Site Settings Desktop Mode option is a duplicate of Desktop site and so we should remove it.
Screenshot_20220623_160737

Steps to reproduce

  1. Go to Site settings
  2. There 2 options Desktop Mode and Desktop site

Actual result

There 2 options Desktop Mode and Desktop site

Expected result

Only Desktop site should be left.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Jun 23, 2022
@samartnik samartnik self-assigned this Jun 24, 2022
@samartnik
Copy link
Contributor Author

Test plan:

  • Check that after upgrade to a newer version there is only 1 option left (Desktop site).
  • Double check that Desktop site option works as intended (when on, all websites open in desktop mode by default and in mobile mode otherwise).
  • Double check that Desktop site option in main menu able to override global option for current web site.
  • Double check that when Desktop Mode option was on prior to upgrade, Desktop site global option is also on after upgrade regardless of its state before upgrade.

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

The above will require 1.41.94 or higher for 1.41.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jul 6, 2022

Please wait till brave/brave-core#14053 gets uplifted into 1.41.x

@srirambv
Copy link
Contributor

srirambv commented Jul 7, 2022

Verification passed on the following devices running 1.41.94 x64 build

  • Verified steps from #23652 (comment)
  • Verified there is only Desktop Site option under Site settings
  • Verified enabling Desktop Site enables it globally on all new tabs and page loads using desktop mode
  • Verified able to override the global settings via the menu settings
  • Verified setting Desktop Mode to enabled on an older version and upgrading to 1.41.94 removes Desktop Mode from settings and sets Desktop Site to enabled
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23652-ARM.mp4
23652-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants