Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Removed duplicate Desktop Mode option #13953

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Jun 24, 2022

Chromium introduced the same option in the same place chromium/chromium@34745fb
So we just remove our implementation.

Resolves brave/brave-browser#23652

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added this to the 1.42.x - Nightly milestone Jun 24, 2022
@samartnik samartnik requested a review from a team as a code owner June 24, 2022 18:26
@samartnik samartnik self-assigned this Jun 24, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Jun 24, 2022
Chromium introduced the same option in the same place chromium/chromium@34745fb
So we just remove our implementation.
@samartnik samartnik force-pushed the android_remove_desktop_mode_option branch from 114deb9 to 40813da Compare June 24, 2022 19:16
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit bd3530f into master Jun 29, 2022
@samartnik samartnik deleted the android_remove_desktop_mode_option branch June 29, 2022 12:22
brave-builds pushed a commit that referenced this pull request Jun 29, 2022
@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.42.48 x64 nightly build

DesktopSite.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Desktop Mode option as it is a duplicate now
4 participants