-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"You can switch between Brave profiles here" message has a Chrome blue background #24466
Comments
Could you please assign me this issue? |
cc: @aguscruiz Can you provide a color for this one. |
I believe this bubble is one of what's called In-product help bubble(IPH bubble) - let me check this out again. So, the new color could be applied to all other IPHs. Is it okay or do you want to change color only for IPH on profile button? |
I think we'll be ok changing it everywhere. If you find a scenario where this wouldn't work, let me know and we can talk about it :) |
Thank you for confirmation! Let me try this one quickly. |
@aguscruiz , I was looking at color configs from the upstream and found there are more colors
Some IPH seems to have a button on it and the button color will apply what we'll change. Let's see what happens. :) |
Yeah, nice catch. It seems Ink drop's radius and border radius don't match. Let me create an issue for it. #25579 |
Verifying as |
Description
Message which says "You can switch between Brave profiles here" is in Chrome blue color. Should be a Brave color/design instead.
Steps to Reproduce
Actual result:
Expected result:
The blue color should be more Brave-ified
Reproduces how often:
easily
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @rebron
The text was updated successfully, but these errors were encountered: