Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You can switch between Brave profiles here" message has a Chrome blue background #24466

Closed
LaurenWags opened this issue Aug 5, 2022 · 11 comments · Fixed by brave/brave-core#15193
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Message which says "You can switch between Brave profiles here" is in Chrome blue color. Should be a Brave color/design instead.

Steps to Reproduce

  1. Create a second profile.
  2. Note message on the new window of second profile is in Chrome blue color, should be Brave-ified.

Actual result:

blue profile msg

Expected result:

The blue color should be more Brave-ified

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.44.23 Chromium: 104.0.5112.81 (Official Build) nightly (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 12.5 (Build 21G72)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes, not new with C104 though
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron

@LaurenWags LaurenWags added design A design change, especially one which needs input from the design team QA/Yes OS/Desktop labels Aug 5, 2022
@rixant
Copy link

rixant commented Aug 5, 2022

Could you please assign me this issue?

@rebron
Copy link
Collaborator

rebron commented Aug 9, 2022

cc: @aguscruiz Can you provide a color for this one.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 9, 2022
@aguscruiz
Copy link

@rixant rixant removed their assignment Aug 11, 2022
@sangwoo108
Copy link

sangwoo108 commented Sep 16, 2022

I believe this bubble is one of what's called In-product help bubble(IPH bubble) - let me check this out again. So, the new color could be applied to all other IPHs. Is it okay or do you want to change color only for IPH on profile button?

@aguscruiz
Copy link

I think we'll be ok changing it everywhere. If you find a scenario where this wouldn't work, let me know and we can talk about it :)

@sangwoo108
Copy link

Thank you for confirmation! Let me try this one quickly.

@sangwoo108 sangwoo108 self-assigned this Sep 16, 2022
@sangwoo108
Copy link

on dark theme

image

on light theme

image

@sangwoo108
Copy link

sangwoo108 commented Sep 23, 2022

@aguscruiz , I was looking at color configs from the upstream and found there are more colors

kColorFeaturePromoBubbleButtonBorder <-- #DADCE0
kColorFeaturePromoBubbleDefaultButtonBackground <-- uses bubble foreground
kColorFeaturePromoBubbleDefaultButtonForeground <-- uses bubble background

Some IPH seems to have a button on it and the button color will apply what we'll change. Let's see what happens. :)

@aguscruiz
Copy link

That color seems to be the same as the browser toolbar background, that's probably it.

Just a head's up, there's something junky happening there with the border radius and also the background. Seems to be 2 different ones acting together
image

@sangwoo108
Copy link

sangwoo108 commented Sep 23, 2022

That color seems to be the same as the browser toolbar background, that's probably it.

Just a head's up, there's something junky happening there with the border radius and also the background. Seems to be 2 different ones acting together image

Yeah, nice catch. It seems Ink drop's radius and border radius don't match. Let me create an issue for it. #25579

@stephendonner
Copy link

Verifying as PASSED, since I logged a follow-up issue: #26290, which we can milestone-triage further, once we have a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants