Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"You can switch between Brave profiles here" message has Chrome-blue background #26290

Closed
stephendonner opened this issue Oct 26, 2022 · 2 comments · Fixed by brave/brave-core#15703
Assignees

Comments

@stephendonner
Copy link

Description

"You can switch between Brave profiles here" message has Chrome-blue background

(This is essentially just #24466 again.)

Steps to Reproduce

  1. install 1.47.19
  2. launch Brave
  3. click on the "hamburger" menu
  4. click Create Profile
  5. type Profile 2 and click Done
  6. wait
  7. notice the background color of the profile button's messaging

Actual result:

Screen Shot 2022-10-26 at 11 14 59 AM

Expected result:

Should be white (Light theme) or black/dark gray (Dark theme)

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.19 Chromium: 107.0.5304.68 (Official Build) nightly (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @LaurenWags @sangwoo108

@sangwoo108
Copy link

It seems regression selecting theme color during profile creation lead to creating custom theme. So the value isn't overriden for it. I'll move values so that it can be overridden regardless of theme.

ref. brave/brave-core#15208 (comment)

cc. @simonhong

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.47.123 Chromium: 108.0.5359.99 (Official Build) beta (x86_64)
Revision 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS macOS Version 13.1 (Build 22C65)
Dark Light
Screenshot 2022-12-11 at 10 56 11 AM Screenshot 2022-12-11 at 10 55 07 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants