Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update back/foreground colors for HelpBubble #15193

Merged
merged 1 commit into from
Sep 24, 2022
Merged

Update back/foreground colors for HelpBubble #15193

merged 1 commit into from
Sep 24, 2022

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Sep 23, 2022

Remove GoogleBlue color.

Resolves brave/brave-browser#24466

on dark theme

image

on light theme

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Create a second profile.
  • Note message on the new window of second profile is in Chrome blue color, should be Brave-ified.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@sangwoo108 sangwoo108 merged commit 86f07d5 into master Sep 24, 2022
@sangwoo108 sangwoo108 deleted the sko/iph branch September 24, 2022 00:16
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"You can switch between Brave profiles here" message has a Chrome blue background
2 participants