Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start sync in the devices modal instead of first render #1094

Merged
merged 1 commit into from
Dec 14, 2018
Merged

start sync in the devices modal instead of first render #1094

merged 1 commit into from
Dec 14, 2018

Conversation

cezaraugusto
Copy link
Contributor

auditors: @darkdh
fix brave/brave-browser#2553

Test Plan:

  • Should be able to create a Sync chain by sharing the sync words
  • Should be able to create a Sync chain by getting the sync words

@cezaraugusto cezaraugusto self-assigned this Dec 13, 2018
darkdh
darkdh reviewed Dec 14, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to reset sync chain when user dismiss dialog and before second device setup

darkdh
darkdh requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also remove

brave-core/components/brave_sync/ui/components/modals/enterSyncCode.tsx

Line 50 in bfa3c54

this.props.actions.onSyncReset()

This will mess up the flow and causing observer double registration

darkdh
darkdh requested changes Dec 14, 2018
View reviewed changes
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also when sync chain is established

  1. click add a new device
  2. dismiss the device dialog, the sync chain will be reset

@cezaraugusto cezaraugusto merged commit 3c8f70e into master Dec 14, 2018
@cezaraugusto cezaraugusto deleted the sync-start branch December 14, 2018 19:54
cezaraugusto added a commit that referenced this pull request Dec 14, 2018
@cezaraugusto
Merge pull request #1094 from brave/sync-start
6af4ce1 
start sync in the devices modal instead of first render
cezaraugusto added a commit that referenced this pull request Dec 14, 2018
@cezaraugusto
Merge pull request #1094 from brave/sync-start
d926b18 
start sync in the devices modal instead of first render
cezaraugusto added a commit that referenced this pull request Dec 14, 2018
@cezaraugusto
Merge pull request #1094 from brave/sync-start
bd216c6 
start sync in the devices modal instead of first render
@cezaraugusto
Copy link
Contributor Author

master 3c8f70e
0.60.x 6af4ce1
0.59.x d926b18
0.58.x bd216c6

@cezaraugusto cezaraugusto mentioned this pull request Dec 17, 2018
Closed
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #1094 from srirambv/srirambv-patch-1
af2a3d2 
Fix about version info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
None yet
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

Sync should start when "Start a new sync chain" is fired and not on first render
3 participants
@cezaraugusto @darkdh @bbondy