Fixed toolbar button color isn't selected properly for custom theme #15208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
force-pushed
the
fix_webstore_theme_color
branch
2 times, most recently
from
6daf7e5 to
bcb37bc
Compare
fix brave/brave-browser#25597 fix brave/brave-browser#25601 Don't overwrite chrome theme's color when custom theme is used on norma profile.
simonhong
force-pushed
the
fix_webstore_theme_color
branch
from
bcb37bc to
d5b40fb
Compare
sangwoo108
approved these changes
Sep 26, 2022
| @@ -0,0 +1,18 @@ | |||
| { | |||
There was a problem hiding this comment.
Hmm, not sure we can add comments to json file type.
simonhong
force-pushed
the
fix_webstore_theme_color
branch
from
d5b40fb to
6a8296c
Compare
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#25597
Don't overwrite chrome theme's color when custom theme is used on norma profile.
Custom theme from webstore:
Brave dark:
Brave light:
GTK theme on linux
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
BraveThemeServiceTest.ColorProviderTestSee the linked issue for manual testing