Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-verified publishers are not displayed #2653

Closed
NejcZdovc opened this issue Dec 19, 2018 · 1 comment · Fixed by brave/brave-core#1160
Closed

Non-verified publishers are not displayed #2653

NejcZdovc opened this issue Dec 19, 2018 · 1 comment · Fixed by brave/brave-core#1160

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Dec 19, 2018

Description

Steps to Reproduce

  1. enable rewards
  2. uncheck allow to non-verified
  3. visit non verified site
  4. open a panel

Actual result:

You will be presented with a rewards summary

Expected result:

Publisher should be displayed

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

broken with #2111

@srirambv
Copy link
Contributor

srirambv commented Jan 18, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Linux
  • Verified non-verified sites are not added to ac list when settings is off
  • Verified non-verified sites are added to ac list when setting is on

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Used test plan from brave/brave-core#1160 and OP.
Found #3015 when testing.

Verified passed with

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment