Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panel for non-verified sites #1160

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fixes panel for non-verified sites #1160

merged 1 commit into from
Dec 20, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Dec 20, 2018

Resolves brave/brave-browser#2653

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • enable rewards
  • visit non verified site (site 1)
  • make sure that is added to ac table
  • uncheck allow to non-verified setting
  • make sure that ac table is empty
  • visit verified site (site 2)
  • make sure that is added to ac table
  • visit non verified site (site 3)
  • make sure that is not listed in the table
  • check allow to non-verified setting
  • make sure that you have site 1 and site 2 in the table
  • visit site 3 again
  • make sure that all 3 sites are listed in ac table

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc merged commit b4a2b38 into master Dec 20, 2018
@NejcZdovc NejcZdovc deleted the non-verified-fix branch December 20, 2018 19:47
NejcZdovc added a commit that referenced this pull request Dec 20, 2018
Fixes panel for non-verified sites
@NejcZdovc
Copy link
Contributor Author

master (0.61) b4a2b38
0.60 a13aaf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-verified publishers are not displayed
3 participants