UI is not reflecting updated backup words for wallet (incorrect backup words shown)

[LaurenWags]

Description

Found while testing #2172 and #3060

In a specific case, the UI is not reflecting updated backup words for wallet. This can lead to a user losing BAT since the backup words being shown do not belong to the wallet addresses shown in the UI.

Steps to Reproduce

1. Install muon (probably 0.25.304 or whatever the last released version we did). Set up data for import (a few bookmarks, history, and definitely enable Payments. Fund wallet as well). Note backup words, wallet addresses, and address/paymentId/CARD_ID from ledger-state file.
2. Install 0.57.18 (Release version) and enable rewards. Note Addresses and backup words as displayed in the UI. Close Rewards page. Close this version. Navigate to ledger_state file and note addresses, paymentID, Card_ID and keyInfoSeed value.
3. Reopen On 0.57.18, import muon data from Brave > Import Bookmarks and Settings in menu (note, I could only get this problem by importing this way. Importing a different way i.e. from brave://welcome or hamburger menu did not produce the issue).
4. Go to Rewards and verify that UI still shows addresses and backup words from step 2
5. Go to ledger_state and verify it shows same values for addresses/paymentId/CARD_ID from muon (step 1). Verify that the keyInfoSeed value is different from step 2.
6. Update 0.57.18 to current released version 0.58.21 by going to chrome://settings/help to trigger the update.
7. Once updated, relaunch Brave to verify update, then close Brave.
8. Rename your profile to be a Beta profile.
9. Launch 0.59.28 Beta version. Navigate to Rewards page.
10. Verify that the UI shows the addresses that are in ledger_state and match muon.

Actual result:

Look at backup words. Backup words are the same as from step 2.

Expected result:

Backup words should have been updated and match those from muon. Since the keyInfoSeed value is different, we should be able to show the correct backup words.

Reproduces how often:

easily using the steps above

Brave version (brave://version info)

Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Mac OS X

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @brave/legacy_qa

[btlechowski]

Reproduced on Window 7 x64

Brave	0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision	eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS	Windows

Used profile provided by @LaurenWags . Thanks!

[LaurenWags]

Verified passed with

Brave	0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision	84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS	Mac OS X

• Verified test plan from Fixes wallet bad state brave-core#1508
• Verified STR from description

Verification passed on

Brave	0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Windows 7

Used test plan from brave/brave-core#1508

Verification passed on

Brave	0.60.40 Chromium: 72.0.3626.109 (Official Build) (64-bit)
Revision	fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS	Linux