Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insufficient funds notification when wallet has more than enough BAT #3212

Closed
LaurenWags opened this issue Feb 4, 2019 · 30 comments · Fixed by brave/brave-core#1592
Closed

Comments

@LaurenWags
Copy link
Member

Description

I just saw on my personal profile that I had a BR notification. When I clicked on it I got a message about insufficient funds, but my monthly budget is 20BAT and my wallet has 64BAT. I should not be getting this message. Since my contribution date is in 2 days, am I just getting the wrong notification? Meaning, should this notification be something like 'Please review your sites, auto contribute is scheduled for 2 days from now'?

Steps to Reproduce

Unsure of steps. My setup was personal profile, wallet is a mix of self-funded and grants. Two days before a-c, notification appeared.

Actual result:

Got insufficient funds notification 2 days before auto contribute is scheduled.
screen shot 2019-02-04 at 1 43 22 pm

Expected result:

No notification, my wallet balance is 64 BAT and my monthly budget is 20 BAT:
screen shot 2019-02-04 at 1 43 32 pm

screen shot 2019-02-04 at 1 44 58 pm

Reproduces how often:

Unsure

Brave version (brave://version info)

Brave 0.61.6 Chromium: 72.0.3626.81 (Official Build) dev (64-bit)
Revision ac8b982e05014492d1bd7d317628a4f22a97ffa0-refs/branch-heads/3626@{#796}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes, experienced on Dev.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @NejcZdovc in case there's any info I can provide before contribution is attempted.

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Feb 4, 2019
@NejcZdovc
Copy link
Contributor

@LaurenWags what do you have for you recurring tips?

@LaurenWags
Copy link
Member Author

@NejcZdovc nothing. no recurring tips.

@mandar-brave
Copy link

@NejcZdovc i am going to prio this to a P2 since it is on the latest build.

@mandar-brave mandar-brave added the priority/P2 A bad problem. We might uplift this to the next planned release. label Feb 5, 2019
@NejcZdovc
Copy link
Contributor

I can't reproduce it, but I think what could be the problem. Will create PR for it

NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 6, 2019
@NejcZdovc NejcZdovc self-assigned this Feb 6, 2019
@RudyMas
Copy link

RudyMas commented Feb 6, 2019

I just want to add. I saw this same message for the 2nd time in a row now. Both on my PC and Laptop. I mean, last month I got this message, and today again. I'm using version 0.59.35 (64bit) now.

I have set both of the Brave Browsers to reward 20BAT among the sites I visit and I have 80BAT in my Brave Wallet. So, plenty of BAT available.

@NejcZdovc
Copy link
Contributor

@RudyMas did the last month contribution went through?

@RudyMas
Copy link

RudyMas commented Feb 6, 2019

No it didn't. Well, I didn't receive any confirmation of it in the Brave Browser about the distribution of the rewards.

The last rewards that was processed successfully, was with the old version of the browser.

@dunxd
Copy link

dunxd commented Feb 8, 2019

I also get this running Brave Version 0.59.35 Chromium: 72.0.3626.81 (Official Build) (64-bit) on MacOS.

I have 20 BAT monthly payment set up, and a balance of 65 BAT. I am able to send Tips fine.

@LaurenWags
Copy link
Member Author

@dunxd - did your contribution go through even though you got this message? fwiw, mine did not:
screen shot 2019-02-08 at 9 04 13 am

@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 13, 2019

Verified passed with

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X
  • Verified test plan from Save wallet properties for ledger brave-core#1592
    "walletProperties":{"altcurrency":"BAT","probi_":"0","balance":0.0,"fee_amount":30.0,"rates":{"BCH":0.000992282271179031,"BTC":0.000033457497883914,"BTG":0.011890612023777545,"DASH":0.001510625167511867,"ETH":0.000988255951926979,"EUR":0.10662618834022236,"LTC":0.002893134272841262,"USD":0.119969158104618,"XRP":0.39677434920773338},

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta(64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Linux
"walletProperties":{"altcurrency":"BAT","probi_":"18000000000000000000","balance":18.0,"fee_amount":30.0,"rates":{"BCH":0.001102425677759284,"BTC":0.000038296050427129,"BTG":0.012263469754351376,"DASH":0.001783603021172033,"ETH":0.00103991283673024,"EUR":0.1261609118855677,"LTC":0.00322697286371651,"USD":0.14272322899419957,"XRP":0.4607114653983304}

Verification passed on

Brave 0.60.34 Chromium: 72.0.3626.109 (Official Build) beta (64-bit)
Revision fae8db7ab9280fa6704a59980263c804f809ebd5-refs/branch-heads/3626@{#857}
OS Windows 10

"walletProperties":{"altcurrency":"BAT","probi_":"40000000000000000000","balance":40.0,"fee_amount":30.0,"rates":{"BCH":0.001066275044831766,"BTC":0.000037324823356013,"BTG":0.011454091415210845,"DASH":0.001720664250486008,"ETH":0.000993608490330668,"EUR":0.12635254761536977,"LTC":0.003088336337310506,"USD":0.14305605919963788,"XRP":0.4522404092202708},"parameters_choices":[20.0,30.0,50.0,85.0,100.0],"parameters_range":[20.0,100.0],"parameters_days":30,"grants":[{"altcurrency":"BAT","probi":"40000000000000000000","expiryTime":1559347200,"promotionId":""}]}}

@eljuno
Copy link

eljuno commented Feb 26, 2019

Users reported that it still not processed with latest 0.60.45 https://community.brave.com/t/no-monthly-rewards-or-tipping-possible/43571?u=eljuno

@mightypenguin
Copy link

I've seen this for at least 3-4 months. In my case I restored my wallet from my existing MUON version of brave to the Chromium based one. My problems only started happening after converting to the Chromium browser. (also on Mac High Sierra) I am often online behind a restrictive firewall. Not sure if that would make a difference.

@RudyMas
Copy link

RudyMas commented Mar 7, 2019

Same for me. It's happening since I also restored my wallet in the Chromium based Brave browser. Although, tipping seems to be working. (I have sent a friend of mine some BAT for his website and he will tell me if he receives it this month. It had been deducted from my saldo.)

@LaurenWags
Copy link
Member Author

@mightypenguin @RudyMas can you both go to brave://settings/help and confirm your Brave version for me?

@mightypenguin
Copy link

I just updated after the last payment failure notification so this probably won't help.

Version 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)

@mightypenguin
Copy link

Just got another insufficient funds notice while I was on a VPN (might just be blocked?).

@RudyMas
Copy link

RudyMas commented Mar 8, 2019

Version 0.60.48 Chromium: 72.0.3626.121 (Official Build) (64-bit)

I have the problem on my Desktop and Laptop. Funds at the moment 90 BAT and both Desktop and Laptop have been set for 20 BAT monthly payment. I lowered it last month to see if this would help. It didn't. :)

@NejcZdovc
Copy link
Contributor

@RudyMas do you have any recurring tips?

@RudyMas
Copy link

RudyMas commented Mar 8, 2019

No. I only tipped 3 websites this month, but none recurring, because I was anticipating the monthly payment would fail again and I wanted to support those 3 this month.

@NejcZdovc
Copy link
Contributor

@RudyMas would really like to solve this mystery. If you have some time please let me know and would love to connect and see if we can see why this is a problem. Please let me know on nejc@brave.com

@RudyMas
Copy link

RudyMas commented Mar 8, 2019

See E-mail. :)

@LaurenWags
Copy link
Member Author

#3640 logged as follow-up issue to this.

@RudyMas
Copy link

RudyMas commented May 4, 2019

image

Sorry guys, still happening. And I just recently added 50 BAT to see if this could help, but nope, still got this message.

image

image

As you can see. 140 BAT in the wallet, and a contribution set voor 20 BAT monthly. I guess there should be enough in my wallet to cover this. :)

Oh, btw, I'm at version:
image

@RudyMas
Copy link

RudyMas commented May 7, 2019

OK, a contribution went out today, but not the 20 BAT I had set, but only 5 BAT.

Just wanted to give an update.

@LaurenWags
Copy link
Member Author

@RudyMas glad a contribution went out for you. In regards to only contributing 5 BAT instead of the 20 you had budgeted, Brave only contributes to verified publishers. So, if you go to brave://rewards page, do you see something like this on the right hand panel? (yours will display a different value for BAT of course):
Screen Shot 2019-05-08 at 5 20 27 PM

@RudyMas
Copy link

RudyMas commented May 9, 2019

Yes. It does. It has about 60 BAT designated.

@LaurenWags
Copy link
Member Author

Thanks @RudyMas - sounds like your auto contribute is occurring, but there are most likely a mix of verified and unverified sites in your auto contribute table. Once we have the monthly statement in place (you can follow progress on that here: #930), you'll have more information about your monthly auto contributions.

@RudyMas
Copy link

RudyMas commented May 9, 2019

Thank you for the information! The monthly statement will probably also help me to keep enough BAT in my wallet to cover it all. That's maybe what went wrong in the past few months.

@Mikeureko
Copy link

Mikeureko commented Jun 27, 2019

I'll chime in and say that I'm getting this same issue. Last month on the 5th (my payment date, not sure if it's universal or not) I was supposed to get 6.5 BAT or so for ads, and it didn't show up in my wallet. I regularly get the "insufficient funds" notification every few days or so. I now have 13.7 BAT pending for ads, I'll update if it goes through this time.

I do not have any auto-contributions set at all and haven't tried tipping anyone yet. The only BAT in my wallet is the 13.1 BAT grant I got last month or so. So I should have a total of 26.8, but again, the ads BAT didn't go through on June 5th.

@Mikeureko
Copy link

Update: I ended up getting the BAT transfer this time. Not sure why the first time didn't work. It's also worth mentioning I got the same "insufficient funds" notification on my Android app, which obviously doesn't even have ads functionality yet, so I don't see how I'd get points on it anyway.

Side note: Any plans to connect the mobile and desktop wallets to be one and the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.