Brave crashes when navigate to More tools->Guest profile>settings menu

[GeetaSarvadnya]

Description

Brave crashes when navigate to More tools->Guest profile>settings menu

Steps to Reproduce

1. Clean profile 1.60.1
2. Click on the hamburger settings menu
3. Click on More tools and select Guest profile
4. Click on settings in guest window

Actual result:

Brave crashes

Uploaded Crash Report ID:	51290100-30cd-ae0a-0000-000000000000
Upload Time:	Thursday, September 7, 2023 at 11:10:05 AM

Expected result:

Should not be any crash

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.60.1 Chromium: 117.0.5938.35 (Official Build) nightly (64-bit)
Revision	d50ecb0
OS	Windows 10 Version 22H2 (Build 19045.3324)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? NA
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin

[mkarolin]

Not related to cr117. Reproduceable in 1.59.76 Chromium: 116.0.5845.163 (Official Build) nightly (64-bit) .
cc: @spylogsster (brave/brave-core#19531)

 	base.dll!logging::LogMessage::~LogMessage() Line 959	C++
 	base.dll!logging::LogMessage::~LogMessage() Line 719	C++
 	base.dll!logging::CheckError::~CheckError() Line 272	C++
 	chrome.dll!BraveVpnHandler::BraveVpnHandler(Profile * profile=0x000002713ed01030) Line 44	C++
 	chrome.dll!std::__Cr::make_unique(Profile * && __args=0x000002713ed01030) Line 686	C++
>	chrome.dll!BraveSettingsUI::BraveSettingsUI(content::WebUI * web_ui=0x000002713e2a9cb0, const std::__Cr::basic_string,std::__Cr::allocator> & host={...}) Line 114	C++

#if BUILDFLAG(IS_WIN) && BUILDFLAG(ENABLE_BRAVE_VPN)
  web_ui->AddMessageHandler(
      std::make_unique(Profile::FromWebUI(web_ui)));
#endif

[LaurenWags]

Added OS/Windows label as this doesn't reproduce on macOS with same version

Brave | 1.59.76 Chromium: 116.0.5845.163 (Official Build) nightly (x86_64)
-- | --
Revision | 882a1d617108cea1c78439e27c5f19c46b276508
OS | macOS Version 13.5.1 (Build 22G90)

[MadhaviSeelam]

Verification PASSED using

Brave | 1.60.81 Chromium: 118.0.5993.54 (Official Build) beta (64-bit)
-- | --
Revision | 1efb3f333eb41cc34af46ca31fb33c30e0afbfae
OS | Windows 11 Version 22H2 (Build 22621.2283)

Reproduced the issue in 1.60.1 Chromium: 117.0.5938.35 nightly using STR #32825 (comment)

1. Installed 1.60.81
2. launched Brave
3. Clicked on the hamburger settings menu
4. Clicked on More tools and select Open Guest profile
5. Clicked on hamburger menu > Settings in guest window

Confirmed no crash and brave://settings page shown as expected

step 4	step 5	result

[kjozwiak]

Removing QA Pass-Win64 as the above will need to be rechecked via 1.59.x now that it's been uplifted via brave/brave-core#20518. The above requires 1.59.119 or higher for 1.59.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.59.120 Chromium: 118.0.5993.88 (Official Build) (64-bit)
-- | --
Revision | 135f92a9af2134bc7d7aeba82f87ff5e68669410
OS | Windows 10 Version 22H2 (Build 19045.3570)

• Verified the STR from the description and ensured there is no crash