Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash for Guest profiles #20041

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fix crash for Guest profiles #20041

merged 1 commit into from
Sep 8, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Sep 7, 2023

Resolves brave/brave-browser#32825
Resolves brave/brave-browser#33581

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • STR from the issue

@spylogsster spylogsster self-assigned this Sep 7, 2023
@spylogsster spylogsster marked this pull request as ready for review September 7, 2023 13:59
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Verification **PASSED** on Win 11 x64` using the following build(s):

Brave | 1.61.21 Chromium: 118.0.5993.70 (Official Build) nightly (64-bit)
-- | --
Revision | ce51937f5b035db1f8c8173fc36df9140494d59a
OS | Windows 11 Version 22H2 (Build 22621.2428)

Reproduced the original issue running 1.60.5 Chromium: 117.0.5938.48 while using the STR/Cases outlined via brave/brave-browser#33581 (comment). Also verified that the crash wasn't occurring with the same STR/Cases using 1.61.21 Chromium: 118.0.5993.70.

kjozwiak pushed a commit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants