Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60. #37552

Closed
mkarolin opened this issue Apr 12, 2024 · 7 comments · Fixed by brave/brave-core#23088
Closed

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60. #37552

mkarolin opened this issue Apr 12, 2024 · 7 comments · Fixed by brave/brave-core#23088

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Apr 12, 2024

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/124.0.6367.29..124.0.6367.60?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@kjozwiak
Copy link
Member

The above requires 1.65.113 or higher for 1.65.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Apr 16, 2024

Quick overview of the work remaining re: affected areas due to C124 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #36346 (comment):

Platforms that still need to check/verify the affected areas due to C124 changes as per #36346 (comment):

  • Android Tablet - Still requires a pass through the affected areas

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.65.113 Chromium: 124.0.6367.60 (Official Build) (64-bit)
-- | --
Revision | c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS | Windows 10 Version 22H2 (Build 19045.4291)

image

@LaurenWags
Copy link
Member

Verified with

Brave	1.65.113 Chromium: 124.0.6367.60 (Official Build) (x86_64) 
Revision	c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS	macOS Version 13.6.6 (Build 22G630)
Screenshot 2024-04-16 at 8 40 39 AM

@btlechowski
Copy link

Verified with

Brave 1.65.113 Chromium: 124.0.6367.60 (Official Build) (64-bit)
Revision c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS Linux

image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using version:

Brave	1.65.113 Chromium: 124.0.6367.60 (Official Build) (64-bit) 
Revision	c1a6c6e73c1f2f1e5bf00a6f0d42065219845887
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • Version bump
  • Branding
Example Example
Screenshot 2024-04-16 at 12 29 01 PM Screenshot 2024-04-16 at 12 26 52 PM

@Uni-verse
Copy link
Contributor

Completed verification on Android ARM Tablet for affected areas in #36346 (comment) for Android ARM tablet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment