Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.49. #23057

Closed
wants to merge 4 commits into from
Closed

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.49. #23057

wants to merge 4 commits into from

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#37552

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Apr 12, 2024
@mkarolin mkarolin self-assigned this Apr 12, 2024
@mkarolin mkarolin requested review from a team as code owners April 12, 2024 18:33
samartnik and others added 2 commits April 12, 2024 16:28
@samartnik
[Android] Changes for logo polish for tablet
e411795 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4a6ecfb34aa32438b180284a909dcd2db639ce8e

[LogoPolish] Implement logo polish for tablet.

This CL modifies the logo height on tablet when Logo Polish is
activated. The height of the logo is decided by the selected variation.
When using split screen mode on a tablet, the logo's height will remain
at the small setting.

The screenshots are included in the following link:
https://docs.google.com/document/d/16z7y1lXiSJ0sCZ0-UzrXdBC8H2idDrVdVarJ4DIEuho/edit?usp=sharing

Bug: 328769923, 330745894
@mkarolin
Disables crashing upstream browser test.
96de837
@mkarolin
Copy link
Collaborator Author

mkarolin commented Apr 15, 2024 •
edited
Loading

Closing in favor of 124.0.6367.60 bump.

@mkarolin mkarolin closed this Apr 15, 2024
@mkarolin mkarolin added this to the Closed milestone Apr 15, 2024
@mkarolin mkarolin deleted the 124.0.6367.49_master branch April 15, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
Closed
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60.
3 participants
@mkarolin @brave-builds @samartnik