Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60. #23088

Merged
merged 4 commits into from
Apr 16, 2024
Merged

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60. #23088

merged 4 commits into from
Apr 16, 2024

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#37552

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

brave-builds and others added 3 commits April 15, 2024 18:56
@brave-builds
Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60
8e9d554
@brave-builds
Update pins list timestamp
4ec4156
@samartnik @mkarolin
[Android] Changes for logo polish for tablet
ae87a8e 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/4a6ecfb34aa32438b180284a909dcd2db639ce8e

[LogoPolish] Implement logo polish for tablet.

This CL modifies the logo height on tablet when Logo Polish is
activated. The height of the logo is decided by the selected variation.
When using split screen mode on a tablet, the logo's height will remain
at the small setting.

The screenshots are included in the following link:
https://docs.google.com/document/d/16z7y1lXiSJ0sCZ0-UzrXdBC8H2idDrVdVarJ4DIEuho/edit?usp=sharing

Bug: 328769923, 330745894
@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Apr 15, 2024
@mkarolin mkarolin self-assigned this Apr 15, 2024
@mkarolin mkarolin requested review from a team as code owners April 15, 2024 19:00
@mkarolin mkarolin mentioned this pull request Apr 15, 2024
Closed
24 tasks
@kjozwiak kjozwiak added this to the 1.67.x - Nightly milestone Apr 16, 2024
@kjozwiak kjozwiak self-requested a review April 16, 2024 21:19
kjozwiak
kjozwiak approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The PrintBrowserTest.PdfWindowDotPrint issue that we're experiencing on Win x64 is known and is being resolved by @darkdh via #23102.

@kjozwiak kjozwiak merged commit bf5fca0 into master Apr 16, 2024
18 of 19 checks passed
@kjozwiak kjozwiak deleted the 124.0.6367.60_master branch April 16, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 124.0.6367.29 to Chromium 124.0.6367.60.
4 participants
@mkarolin @kjozwiak @brave-builds @samartnik