Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push wallet result to UI side in extension observer: OnWalletInitialized #3974

Closed
jasonrsadler opened this issue Apr 2, 2019 · 1 comment · Fixed by brave/brave-core#2233

Comments

@jasonrsadler
Copy link

jasonrsadler commented Apr 2, 2019

Follow up from brave/brave-core#2097

Description

extension observer method OnWalletInitialized is iterating on wallet creation result on native side. We would like this result to be pushed to client side code and iterated there.

Function in question: https://github.com/brave/brave-core/blob/master/components/brave_rewards/browser/extension_rewards_service_observer.cc#L29-L55

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

dev issue

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2019

Verification passed on

Brave 0.65.93 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants