Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewards panel now opens in 'First Run' state with Rewards page when wallet is corrupt #2097

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Rewards panel now opens in 'First Run' state with Rewards page when wallet is corrupt #2097

merged 1 commit into from
Apr 15, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Mar 27, 2019 •
edited by NejcZdovc
Loading

Resolves brave/brave-browser#3697

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Open Brave with this profile https://github.com/brave/brave-browser/files/2823589/Brave-Browser-Beta-05925.zip
  2. Click Rewards panel and make sure that panel is at 'First Run' 'Join Now' screen.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler added this to the 0.64.x - Nightly milestone Mar 27, 2019
@jasonrsadler jasonrsadler self-assigned this Mar 27, 2019
@jasonrsadler jasonrsadler force-pushed the corrupt-panel branch 2 times, most recently from 8f56f6b to d5fb96c Compare March 27, 2019 18:08
@jasonrsadler jasonrsadler mentioned this pull request Apr 2, 2019
Closed
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 2, 2019 18:21
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 5, 2019 10:25
NejcZdovc
NejcZdovc previously requested changes Apr 5, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me it shows enable rewards and not join now. One thing that you need to be carful with this profile is that is has UserData folder inside which you need to copy into the root folder if you are on mac

image

@jasonrsadler jasonrsadler force-pushed the corrupt-panel branch 2 times, most recently from f27a95b to 3642995 Compare April 7, 2019 02:26
@jasonrsadler jasonrsadler dismissed NejcZdovc’s stale review April 7, 2019 02:27

Fixes OnTimer crash when opening panel by running sanity check on wallet during getGrants

@jasonrsadler jasonrsadler requested a review from NejcZdovc April 7, 2019 02:27
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 10, 2019 •
edited
Loading

blocked on #2122, as provided profile crashes because of db upgrade bug

NejcZdovc
NejcZdovc previously approved these changes Apr 11, 2019
View reviewed changes
@jasonrsadler jasonrsadler requested a review from NejcZdovc April 11, 2019 13:03
@jasonrsadler jasonrsadler force-pushed the corrupt-panel branch 2 times, most recently from 63539c0 to 6117edc Compare April 12, 2019 17:34
Fixes brave/brave-browser#3697
546f45b 
Removed comment

Moved corrupt wallet check after state files load

Removed extension value

Addressing comments

Run sanity check on panel open to check wallet state.

lint
@jasonrsadler jasonrsadler merged commit e85125a into master Apr 15, 2019
@jasonrsadler jasonrsadler deleted the corrupt-panel branch April 15, 2019 10:03
@LaurenWags LaurenWags mentioned this pull request May 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@tmancey tmancey Awaiting requested review from tmancey

@mkarolin mkarolin Awaiting requested review from mkarolin

@ryanml ryanml Awaiting requested review from ryanml

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.65.x - Release
Development

Successfully merging this pull request may close these issues.

Brave Panel always shows Brave Rewards is off on corrupted profile
2 participants
@jasonrsadler @NejcZdovc