Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theverge.com (among other sites) hang/delay before rendering in Brave #4402

Closed
Brave-Matt opened this issue May 10, 2019 · 2 comments · Fixed by brave/brave-core#2488
Closed
Labels
feature/shields/adblock Blocking ads & trackers with Shields priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@Brave-Matt
Copy link

Description

I’m wondering if anyone can tell me what causes some sites to have a short “delay” before rendering (and rendering correctly).
For example, theverge.com and overclockers.co.uk both have this behavior (off the top of my head, i believe there are more I’ve encountered) but do load as intended. These sites load much faster in Chrome. In Brave you generally get ~1-3 second delay:

image

@snyderp notes the logic at play:

<style>.async-hide { opacity: 0 !important} </style>
<script>(function(a,s,y,n,c,h,i,d,e){s.className+=' '+y;h.start=1*new Date;
h.end=i=function(){s.className=s.className.replace(RegExp(' ?'+y),'')};
(a[n]=a[n]||[]).hide=h;setTimeout(function(){i();h.end=null},c);h.timeout=c;
})(window,document.documentElement,'async-hide','dataLayer',4000,
{'GTM-54FC4VZ':true});</script>

Further, it seems that the script says "Delay render for 4000ms (4s) unless "google optimize" is detected.

Steps to Reproduce

  1. Visit theverge.com or overclockers.co.uk (for example)
  2. Note the page delay on load before rendering

Reproduces how often:

Always

Version/Channel Information:

This issue occurs in all channels Release - Nightly

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No, but it seems as though the delay may be slightly shortened although it's hard to tell. Regardless, rendering time is still comparatively slow to Chrome and Chrome + uBO which render the site instantly.

Miscellaneous Information:

User report: https://community.brave.com/t/slow-rendering-https-www-overclockers-co-uk/59075/4

@Brave-Matt Brave-Matt added feature/shields/adblock Blocking ads & trackers with Shields webcompat/not-shields-related Sites are breaking because of something other than Shields. labels May 10, 2019
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 11, 2019
@bbondy
Copy link
Member

bbondy commented May 11, 2019

weird, thanks for the report!

pes10k added a commit to brave/brave-core that referenced this issue May 24, 2019
pes10k added a commit to brave/brave-core that referenced this issue Jun 18, 2019
pes10k pushed a commit to brave/brave-core that referenced this issue Jun 19, 2019
bsclifton added a commit to brave/brave-core that referenced this issue Jun 23, 2019
…s-code_0.67.x

add google analytics polyfill, fixes brave/brave-browser#4402 (uplift to 0.67.x)
@bsclifton bsclifton added this to the 0.67.x - Dev milestone Jun 24, 2019
@pes10k pes10k modified the milestones: 0.67.x - Dev, 0.66.x - Beta Jun 24, 2019
pes10k pushed a commit to brave/brave-core that referenced this issue Jun 24, 2019
…s-code_0.66.x

add google analytics polyfill, fixes brave/brave-browser#4402 (uplift to 0.66.x)
@LaurenWags
Copy link
Member

LaurenWags commented Jun 25, 2019

Verified passed with

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Linux
  • Verified page load was instantaneous

Verification passed on

Brave 0.66.98 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified page load was instantaneous

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants