Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave-core builds fail to create usable linux-x64.zip archives #479

Closed
bkero opened this issue Jul 3, 2018 · 1 comment
Closed

Brave-core builds fail to create usable linux-x64.zip archives #479

bkero opened this issue Jul 3, 2018 · 1 comment
Assignees
@mbacchi
Labels
OS/Linux QA/No
Milestone
0.55.x - Release ...

Comments

@bkero
Copy link
Contributor

bkero commented Jul 3, 2018

Description

Brave core builds fail to include all the necessary files to run a build. Here is a list of files:

./locales
./locales/hi.pak
./locales/es.pak
./locales/ta.pak
./locales/vi.pak
./locales/pt-PT.pak
./locales/he.pak
./locales/en-US.pak
./locales/da.pak
./locales/pt-BR.pak
./locales/sw.pak
./locales/ro.pak
./locales/ja.pak
./locales/fa.pak
./locales/th.pak
./locales/id.pak
./locales/fil.pak
./locales/lt.pak
./locales/am.pak
./locales/sr.pak
./locales/ru.pak
./locales/sl.pak
./locales/ar.pak
./locales/kn.pak
./locales/bg.pak
./locales/el.pak
./locales/lv.pak
./locales/mr.pak
./locales/de.pak
./locales/et.pak
./locales/it.pak
./locales/nl.pak
./locales/ca.pak
./locales/te.pak
./locales/uk.pak
./locales/sv.pak
./locales/sk.pak
./locales/cs.pak
./locales/ml.pak
./locales/fi.pak
./locales/zh-TW.pak
./locales/hu.pak
./locales/zh-CN.pak
./locales/fr.pak
./locales/en-GB.pak
./locales/pl.pak
./locales/hr.pak
./locales/nb.pak
./locales/ms.pak
./locales/ko.pak
./locales/bn.pak
./locales/tr.pak
./locales/gu.pak
./locales/es-419.pak
./LICENSE
./version
./LICENSES.chromium.html
./brave_resources.pak
./brave

Running this yields the error:

$ ./brave
[0703/161636.545783:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.
Trace/breakpoint trap (core dumped)

Running this with strace reveals that it's failing to load a file (and once the file is there, many others):

$ strace -f ./brave
...
**openat(AT_FDCWD, "/home/bkero/Downloads/brave/icudtl.dat", O_RDONLY) = -1 ENOENT (No such file or directory)**
mprotect(0x556887dd0000, 604, PROT_READ|PROT_WRITE) = 0
mprotect(0x556887dd0000, 672, PROT_READ|PROT_WRITE) = 0
futex(0x7fc04f73f0e8, FUTEX_WAKE_PRIVATE, 2147483647) = 0
mprotect(0x556887dd0000, 712, PROT_READ) = 0
futex(0x55688fbf57a0, FUTEX_WAKE_PRIVATE, 2147483647) = 0
openat(AT_FDCWD, "/etc/localtime", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=2845, ...}) = 0
fstat(3, {st_mode=S_IFREG|0644, st_size=2845, ...}) = 0
read(3, "TZif2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\5\0\0\0\5\0\0\0\0"..., 4096) = 2845
lseek(3, -1811, SEEK_CUR)               = 1034
read(3, "TZif2\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\5\0\0\0\5\0\0\0\0"..., 4096) = 1811
close(3)                                = 0
write(2, "[0703/161719.980845:ERROR:icu_ut"..., 90[0703/161719.980845:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.
) = 90
--- SIGTRAP {si_signo=SIGTRAP, si_code=SI_KERNEL} ---
+++ killed by SIGTRAP (core dumped) +++
Trace/breakpoint trap (core dumped)

If I compare the files of a RPM build:

./opt
./opt/brave.com
./opt/brave.com/brave
./opt/brave.com/brave/chrome_100_percent.pak
./opt/brave.com/brave/icudtl.dat
./opt/brave.com/brave/chrome_200_percent.pak
./opt/brave.com/brave/locales
./opt/brave.com/brave/locales/hi.pak
./opt/brave.com/brave/locales/es.pak
./opt/brave.com/brave/locales/ta.pak
./opt/brave.com/brave/locales/vi.pak
./opt/brave.com/brave/locales/pt-PT.pak
./opt/brave.com/brave/locales/he.pak
./opt/brave.com/brave/locales/en-US.pak
./opt/brave.com/brave/locales/da.pak
./opt/brave.com/brave/locales/pt-BR.pak
./opt/brave.com/brave/locales/sw.pak
./opt/brave.com/brave/locales/ro.pak
./opt/brave.com/brave/locales/ja.pak
./opt/brave.com/brave/locales/fa.pak
./opt/brave.com/brave/locales/th.pak
./opt/brave.com/brave/locales/id.pak
./opt/brave.com/brave/locales/fil.pak
./opt/brave.com/brave/locales/lt.pak
./opt/brave.com/brave/locales/am.pak
./opt/brave.com/brave/locales/sr.pak
./opt/brave.com/brave/locales/ru.pak
./opt/brave.com/brave/locales/sl.pak
./opt/brave.com/brave/locales/ar.pak
./opt/brave.com/brave/locales/kn.pak
./opt/brave.com/brave/locales/bg.pak
./opt/brave.com/brave/locales/el.pak
./opt/brave.com/brave/locales/lv.pak
./opt/brave.com/brave/locales/mr.pak
./opt/brave.com/brave/locales/de.pak
./opt/brave.com/brave/locales/et.pak
./opt/brave.com/brave/locales/it.pak
./opt/brave.com/brave/locales/nl.pak
./opt/brave.com/brave/locales/ca.pak
./opt/brave.com/brave/locales/te.pak
./opt/brave.com/brave/locales/uk.pak
./opt/brave.com/brave/locales/sv.pak
./opt/brave.com/brave/locales/sk.pak
./opt/brave.com/brave/locales/cs.pak
./opt/brave.com/brave/locales/ml.pak
./opt/brave.com/brave/locales/fi.pak
./opt/brave.com/brave/locales/zh-TW.pak
./opt/brave.com/brave/locales/hu.pak
./opt/brave.com/brave/locales/zh-CN.pak
./opt/brave.com/brave/locales/fr.pak
./opt/brave.com/brave/locales/en-GB.pak
./opt/brave.com/brave/locales/pl.pak
./opt/brave.com/brave/locales/hr.pak
./opt/brave.com/brave/locales/nb.pak
./opt/brave.com/brave/locales/ms.pak
./opt/brave.com/brave/locales/ko.pak
./opt/brave.com/brave/locales/bn.pak
./opt/brave.com/brave/locales/tr.pak
./opt/brave.com/brave/locales/gu.pak
./opt/brave.com/brave/locales/es-419.pak
./opt/brave.com/brave/brave-browser
./opt/brave.com/brave/resources.pak
./opt/brave.com/brave/product_logo_64.png
./opt/brave.com/brave/product_logo_32.png
./opt/brave.com/brave/xdg-mime
./opt/brave.com/brave/natives_blob.bin
./opt/brave.com/brave/swiftshader
./opt/brave.com/brave/swiftshader/libGLESv2.so
./opt/brave.com/brave/swiftshader/libEGL.so
./opt/brave.com/brave/product_logo_24.png
./opt/brave.com/brave/product_logo_32.xpm
./opt/brave.com/brave/product_logo_16.png
./opt/brave.com/brave/MEIPreload
./opt/brave.com/brave/MEIPreload/preloaded_data.pb
./opt/brave.com/brave/MEIPreload/manifest.json
./opt/brave.com/brave/brave-sandbox
./opt/brave.com/brave/product_logo_22.png
./opt/brave.com/brave/v8_context_snapshot.bin
./opt/brave.com/brave/default-app-block
./opt/brave.com/brave/product_logo_128.png
./opt/brave.com/brave/product_logo_256.png
./opt/brave.com/brave/resources
./opt/brave.com/brave/resources/brave_extension
./opt/brave.com/brave/resources/brave_extension/_locales
./opt/brave.com/brave/resources/brave_extension/_locales/kn
./opt/brave.com/brave/resources/brave_extension/_locales/kn/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/nl
./opt/brave.com/brave/resources/brave_extension/_locales/nl/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/no
./opt/brave.com/brave/resources/brave_extension/_locales/no/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/sl
./opt/brave.com/brave/resources/brave_extension/_locales/sl/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/hi
./opt/brave.com/brave/resources/brave_extension/_locales/hi/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/fi
./opt/brave.com/brave/resources/brave_extension/_locales/fi/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/en_US
./opt/brave.com/brave/resources/brave_extension/_locales/en_US/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ml
./opt/brave.com/brave/resources/brave_extension/_locales/ml/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/vi
./opt/brave.com/brave/resources/brave_extension/_locales/vi/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/lv
./opt/brave.com/brave/resources/brave_extension/_locales/lv/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/pl
./opt/brave.com/brave/resources/brave_extension/_locales/pl/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/sv
./opt/brave.com/brave/resources/brave_extension/_locales/sv/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/mr
./opt/brave.com/brave/resources/brave_extension/_locales/mr/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/sr
./opt/brave.com/brave/resources/brave_extension/_locales/sr/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/zh_CN
./opt/brave.com/brave/resources/brave_extension/_locales/zh_CN/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/et
./opt/brave.com/brave/resources/brave_extension/_locales/et/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ar
./opt/brave.com/brave/resources/brave_extension/_locales/ar/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/lt
./opt/brave.com/brave/resources/brave_extension/_locales/lt/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/pt_BR
./opt/brave.com/brave/resources/brave_extension/_locales/pt_BR/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ms
./opt/brave.com/brave/resources/brave_extension/_locales/ms/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ca
./opt/brave.com/brave/resources/brave_extension/_locales/ca/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/it
./opt/brave.com/brave/resources/brave_extension/_locales/it/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/th
./opt/brave.com/brave/resources/brave_extension/_locales/th/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/fr
./opt/brave.com/brave/resources/brave_extension/_locales/fr/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/da
./opt/brave.com/brave/resources/brave_extension/_locales/da/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/en_GB
./opt/brave.com/brave/resources/brave_extension/_locales/en_GB/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ro
./opt/brave.com/brave/resources/brave_extension/_locales/ro/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/cs
./opt/brave.com/brave/resources/brave_extension/_locales/cs/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/es_419
./opt/brave.com/brave/resources/brave_extension/_locales/es_419/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/uk
./opt/brave.com/brave/resources/brave_extension/_locales/uk/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/he
./opt/brave.com/brave/resources/brave_extension/_locales/he/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/tr
./opt/brave.com/brave/resources/brave_extension/_locales/tr/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/hu
./opt/brave.com/brave/resources/brave_extension/_locales/hu/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/bg
./opt/brave.com/brave/resources/brave_extension/_locales/bg/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/fa
./opt/brave.com/brave/resources/brave_extension/_locales/fa/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/pt_PT
./opt/brave.com/brave/resources/brave_extension/_locales/pt_PT/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/es
./opt/brave.com/brave/resources/brave_extension/_locales/es/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/el
./opt/brave.com/brave/resources/brave_extension/_locales/el/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/sw
./opt/brave.com/brave/resources/brave_extension/_locales/sw/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/zh_TW
./opt/brave.com/brave/resources/brave_extension/_locales/zh_TW/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/te
./opt/brave.com/brave/resources/brave_extension/_locales/te/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/de
./opt/brave.com/brave/resources/brave_extension/_locales/de/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ru
./opt/brave.com/brave/resources/brave_extension/_locales/ru/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/id
./opt/brave.com/brave/resources/brave_extension/_locales/id/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/gu
./opt/brave.com/brave/resources/brave_extension/_locales/gu/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/sk
./opt/brave.com/brave/resources/brave_extension/_locales/sk/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/bn
./opt/brave.com/brave/resources/brave_extension/_locales/bn/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ko
./opt/brave.com/brave/resources/brave_extension/_locales/ko/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ja
./opt/brave.com/brave/resources/brave_extension/_locales/ja/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/am
./opt/brave.com/brave/resources/brave_extension/_locales/am/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/hr
./opt/brave.com/brave/resources/brave_extension/_locales/hr/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/ta
./opt/brave.com/brave/resources/brave_extension/_locales/ta/messages.json
./opt/brave.com/brave/resources/brave_extension/_locales/fil
./opt/brave.com/brave/resources/brave_extension/_locales/fil/messages.json
./opt/brave.com/brave/brave_resources.pak
./opt/brave.com/brave/xdg-settings
./opt/brave.com/brave/product_logo_48.png
./opt/brave.com/brave/extensions
./opt/brave.com/brave/brave
./usr
./usr/bin
./usr/bin/brave-browser-stable
./usr/share
./usr/share/appdata
./usr/share/appdata/brave-browser.appdata.xml
./usr/share/applications
./usr/share/applications/brave-browser.desktop
./usr/share/gnome-control-center
./usr/share/gnome-control-center/default-apps
./usr/share/gnome-control-center/default-apps/brave-browser.xml
./usr/share/man
./usr/share/man/man1
./usr/share/man/man1/brave-browser.1.gz
./usr/share/man/man1/brave-browser-stable.1.gz
./etc
./etc/cron.daily
./etc/cron.daily/brave-browser
./brave-x86_64.rpm

Steps to Reproduce

  1. Download the latest brave-x64.zip build from https://github.com/brave/brave-browser-builds
  2. Unzip the file
  3. Attempt to run the binary from the archive

Actual result:

$ ./brave
[0703/161636.545783:ERROR:icu_util.cc(133)] Invalid file descriptor to ICU data received.
Trace/breakpoint trap (core dumped)

Expected result:

Browser runs

Reproduces how often:

Always

Brave version (about:brave info)

Latest core

Reproducible on current release:

Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information
@simonhong
Copy link
Member

I think we should fill all missing resources to source of brave:brave_dist_resources target.

@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@mbacchi mbacchi self-assigned this Jul 26, 2018
mbacchi added a commit to brave/brave-core that referenced this issue Aug 1, 2018
@mbacchi
Add missing requirements to Linux zip
9b2a5ce 
The brave binary will now function when started from the
Linux zip package.

Fixes brave/brave-browser#479
@mbacchi mbacchi mentioned this issue Aug 1, 2018
Merged
9 tasks
yrliou pushed a commit to brave/brave-core that referenced this issue Aug 9, 2018
@mbacchi @yrliou
Add missing requirements to Linux zip
57ef653 
The brave binary will now function when started from the
Linux zip package.

Fixes brave/brave-browser#479
@bbondy bbondy added the QA/No label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbacchi mbacchi

Labels
OS/Linux QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@bkero @bbondy @mbacchi @simonhong @srirambv