Add missing requirements to Linux zip #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The brave binary will now function when started from the Linux zip package. Fixes brave/brave-browser#479
bridiver
reviewed
Aug 1, 2018
| ] | ||
|
|
||
| if (!is_mac) { | ||
| sources += [ |
There was a problem hiding this comment.
it seems like we have too many pak files here, they should be consolidated into 3 using repack if they aren't already (brave (or maybe chrome to avoid patching)/100/200)
There was a problem hiding this comment.
Yep right. Created issue for this (brave/brave-browser#672).
petemill
added a commit
that referenced
this pull request
Dec 11, 2018
Changes: ``` * cee363d - (44 minutes ago) Merge pull request #314 from brave/revert-sync-master — Pete Miller (HEAD -> master, origin/master, origin/HEAD) |\ | * 0ca4b73 - (56 minutes ago) Revert "sync v2" — Cezar Augusto | * a479cea - (56 minutes ago) Revert "Merge pull request #308 from brave/sync_img" — Cezar Augusto |/ * dd46eab - (19 hours ago) Merge pull request #247 from brave/c71-clock-period — Pete Miller |\ | * 20d2a61 - (7 weeks ago) Fix NTP clock for c71 — petemill (origin/c71-clock-period, c71-clock-period) * | 69a3399 - (19 hours ago) Merge pull request #305 from ryanml/android-rewards-title-fix — Pete Miller |\ \ | |/ |/| | * d92ce8f - (7 days ago) Fixing rewards toggle for long translations — ryanml (ryanml/android-rewards-title-fix, android-rewards-title-fix) |/ * 4692dfd - (25 hours ago) readme typos — Ross Moody * ca3e285 - (29 hours ago) Merge pull request #312 from emerick/rewards-backup-wallet-notification — Nejc Zdovc |\ | * 4dda1bc - (4 days ago) Add support for backupWallet notification — Emerick Rogul * | 0a5f56e - (4 days ago) Emoji Life — Ross Moody * | be16816 - (4 days ago) Readme formatting — Ross Moody * | 35b166d - (4 days ago) Brave UI Logo — Ross Moody * | fddeb8a - (4 days ago) Merge pull request #311 from brave/now-deploy-static — Cezar Augusto |\ \ | * | 6685301 - (5 days ago) Use new static deploy config for now instead of docker — petemill (origin/now-deploy-static, now-deploy-static) * | | eb49e8b - (4 days ago) remove list from README file — Cezar Augusto * | | 59eae8d - (4 days ago) remove outdated docs — Cezar Augusto * | | f04fecc - (4 days ago) do not count first letter if space in textareaclipboard — Cezar Augusto | |/ |/| * | 7ea9178 - (5 days ago) Merge pull request #308 from brave/sync_img — Cezar Augusto |\ \ | * | 470233f - (6 days ago) make sync images exportable — Cezar Augusto | |/ * | aa520cf - (5 days ago) Merge pull request #309 from brave/welcome_img — Pete Miller |\ \ | * | 870d3ba - (6 days ago) animation dial in — Ross Moody (origin/welcome_img, welcome_img) | * | 1c2525b - (6 days ago) make welcome page images exportable — Cezar Augusto | |/ * | 96ccb12 - (6 days ago) Merge pull request #307 from kirkins/patch-1 — Ryan Lanese |\ \ | * | f98a665 - (6 days ago) small typo — Philip Kirkbride * | | f3c38e1 - (6 days ago) v0.36.0 — ryanml (tag: v0.36.0) |/ / * | 46b3501 - (6 days ago) Merge pull request #304 from ryanml/disabled-panel — Nejc Zdovc |\ \ | * | 6be56a3 - (7 days ago) Adding disabledPanel component — ryanml (ryanml/disabled-panel) |/ / * | 79b16fb - (6 days ago) Merge pull request #299 from ryanml/fix-298 — Nejc Zdovc |\ \ | |/ |/| | * c79530c - (12 days ago) Fixes #298, uses string type for amount/tokens — ryanml (ryanml/fix-298, fix-298) * 6bf8054 - (8 days ago) v0.35.0 — Cezar Augusto (tag: v0.35.0, now-deploy-reliable) * 3535427 - (3 weeks ago) sync v2 — Cezar Augusto * 10f07c0 - (9 days ago) Merge pull request #300 from brave/site-banner-icon — Ryan Lanese |\ | * da3cc4b - (11 days ago) Site banner icon update — Ross Moody * 9064f12 - (9 days ago) Merge pull request #301 from emerick/rewards-insufficient-funds-notification — Ryan Lanese * 5300262 - (11 days ago) Add support for insufficientFunds notification — Emerick Rogul ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The brave binary will now function when started from the
Linux zip package.
Fixes brave/brave-browser#479
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: