Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some styles in webtorrent affect global space in storybook #5662

Closed
cezaraugusto opened this issue Aug 14, 2019 · 1 comment · Fixed by brave/brave-core#3178
Closed

Some styles in webtorrent affect global space in storybook #5662

cezaraugusto opened this issue Aug 14, 2019 · 1 comment · Fixed by brave/brave-core#3178
Assignees
@cezaraugusto
Labels
dev/storybook dev-setup QA/No release-notes/exclude
Milestone
0.70.x - Release

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Aug 14, 2019 •
edited
Loading

after brave/brave-core#3146 storybook broke since some webtorrent props changed and not reflected in storybook
@cezaraugusto cezaraugusto added this to the 0.71.x - Nightly milestone Aug 14, 2019
@cezaraugusto
Copy link
Contributor Author

fixed by brave/brave-core#3163

@cezaraugusto cezaraugusto self-assigned this Aug 14, 2019
@cezaraugusto cezaraugusto reopened this Aug 14, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 14, 2019
@cezaraugusto
update webtorrent storybook
272423d 
fix brave/brave-browser#5662

storybook went broken after #3146.
this PR fixes it by updating webtorrent's props in storybook
@cezaraugusto cezaraugusto mentioned this issue Aug 14, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
dev/storybook dev-setup QA/No release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

update webtorrent storybook brave/brave-core
3 participants
@kjozwiak @cezaraugusto @imptrx