WebTorrent: Add "Save All Files..." feature #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
force-pushed
the
webtorrent-save-all2
branch
3 times, most recently
from
2017846 to
e515586
Compare
yrliou
reviewed
Aug 13, 2019
yrliou
reviewed
Aug 13, 2019
| "@types/parse-torrent": "^5.8.3", | ||
| "@types/webtorrent": "^0.98.5", | ||
| "bignumber.js": "^7.2.1", | ||
| "bluebird": "^3.5.1", | ||
| "clipboard-copy": "^2.0.0", | ||
| "jszip": "^3.2.2", |
There was a problem hiding this comment.
cc @diracdeltas for adding a new dep here.
yrliou
reviewed
Aug 13, 2019
| @@ -7,7 +7,7 @@ | |||
| "scripts": ["extension/out/brave_webtorrent_background.bundle.js"], | |||
| "persistent": true | |||
| }, | |||
| "permissions": ["dns", "tabs", "windows", "<all_urls>"], | |||
| "permissions": ["downloads", "dns", "tabs", "windows", "<all_urls>"], | |||
There was a problem hiding this comment.
cc @diracdeltas for granting a new permission to webtorrent extension.
Currently there is no ability to save all files at once. User has to save each file separately. This commit fixes that. Fixes: brave/brave-browser#1230
feross
force-pushed
the
webtorrent-save-all2
branch
from
e515586 to
31af2e6
Compare
|
Force pushed with the stray |
yrliou
approved these changes
Aug 13, 2019
|
I'm going to merge it here without waiting for CI again since the latest force push only had a |
cezaraugusto
added a commit
that referenced
this pull request
Aug 14, 2019
fix brave/brave-browser#5662 storybook went broken after #3146. this PR fixes it by updating webtorrent's props in storybook
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no ability to save all files at once. The user has to save each file separately. This PR fixes that.
Fixes: brave/brave-browser#1230
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.