Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove left-over theme step code from brave://welcome #7461

Closed
bsclifton opened this issue Dec 19, 2019 · 0 comments · Fixed by brave/brave-core#4266
Closed

Remove left-over theme step code from brave://welcome #7461

bsclifton opened this issue Dec 19, 2019 · 0 comments · Fixed by brave/brave-core#4266
Assignees
@bsclifton
Labels
dev-concern QA/No release-notes/exclude
Milestone
1.4.x - Release

Comments

@bsclifton
Copy link
Member

Description

The theme step was removed from brave://welcome when fixing #5632, however there is a lot of dead code that was not removed with brave/brave-core#3242

We should remove a lot of the dead code which was originally added with brave/brave-core#2909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
dev-concern QA/No release-notes/exclude
Projects
None yet
Milestone
1.4.x - Release
Development

Successfully merging a pull request may close this issue.

Remove left-over "Theme" content from welcome screen brave/brave-core
1 participant
@bsclifton