Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove left-over "Theme" content from welcome screen #4266

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 19, 2019

"Theme" screen was originally added with #2909

Fixes brave/brave-browser#7461

Submitter Checklist:

Test Plan:

N/A

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong
Copy link
Member

It would be good to delete also the related extension apis like brave.theme.setBraveThemeType and dark_mode::SetBraveDarkModeType(const std::string&).

@bsclifton
Copy link
Member Author

It would be good to delete also the related extension apis like brave.theme.setBraveThemeType and dark_mode::SetBraveDarkModeType(const std::string&).

Those might still be used by the appearance page- I'll check on that

@simonhong
Copy link
Member

simonhong commented Dec 19, 2019

It would be good to delete also the related extension apis like brave.theme.setBraveThemeType and dark_mode::SetBraveDarkModeType(const std::string&).

Those might still be used by the appearance page- I'll check on that

I think left as-is would be better than deleting.
appearance handler doesn't use it for setting/getting brave theme type, instead custom message handlers are used.
I think re-reuse this extension apis at there would be better than using additional message handler.
I can do this cleanup later.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton
Copy link
Member Author

Only failed on optional test-install (macOS) step; should be good to go! 😄👍
https://ci.brave.com/job/brave-browser-build-pr/job/bsc-remove-welcome-theme/1/execution/node/706/log/

@bsclifton bsclifton merged commit c88f0f7 into master Dec 20, 2019
@bsclifton bsclifton deleted the bsc-remove-welcome-theme branch December 20, 2019 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove left-over theme step code from brave://welcome
2 participants