Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #6879 - Target is sometimes not shown fully on panel captcha #7597

Closed
btlechowski opened this issue Jan 4, 2020 · 3 comments · Fixed by brave/brave-core#4735

Comments

@btlechowski
Copy link

Follow up to #6879. The issue still reproduces.

Description

Target is sometimes not shown fully on panel captcha. Probably similar to #2956 but device DPI settings were 100%.

Steps to Reproduce

  1. Set locale to Japan and device DPI to 100%(default)
  2. Set env to staging to trigger grant
  3. Open panel, sometimes one of the target is not fully shown due to extra padding on message for other locales

Actual result:

image

Expected result:

Should always show the targets fully

Reproduces how often:

Easy but needs a few retries of failed attempts

Brave version (brave://version info)

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @NejcZdovc @ryanml @rebron

@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.3.85

image

@btlechowski
Copy link
Author

Still reproducible on German locale

Brave 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Ubuntu 18.04 LTS

image

@btlechowski
Copy link
Author

btlechowski commented Mar 18, 2020

Awesome work!

Verification passed on

Brave 1.7.65 Chromium: 80.0.3987.132 (Official Build) dev (64-bit)
Revision fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#4735
BR Panel
image
image
Verified I was able to to claim the grant

BR Settings Page
image
Verified I was able to to claim the grant

Verified test plan from the description
image
image


Verified passed with

Brave 1.7.66 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Panel:
Screen Shot 2020-03-19 at 1 39 55 PM
Screen Shot 2020-03-19 at 1 40 02 PM
Screen Shot 2020-03-19 at 1 40 18 PM

Settings page:
Screen Shot 2020-03-19 at 1 52 12 PM
Screen Shot 2020-03-19 at 1 52 23 PM

  • Verified STR from description (5x each) for both Japanese and German. Also confirmed I was able to solve the captcha.

スクリーンショット 2020-03-19 午後1 54 40

Bildschirmfoto 2020-03-19 um 1 55 59 PM

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Settings page:- Able to claim grants from brave rewards settings page
image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants