Fix partially hidden grant captcha drag and drop target image #4735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7597
Resolves brave/brave-browser#7147
Currently, when the grant captcha title text spans more than one line the drag-and-drop target image can extend below the bottom border of the rewards extension popup. This is because the
GrantWrapper
is an absolutely positioned overlay (rendered on top of the wallet UI), and absolutely positioned elements without explicit height to not grow the height of their parent.This change modifies the rewards extension so that
GrantWrapper
is relatively positioned and the wallet UI is not rendered at the same time.GrantWrapper
is also used in the promotions component of the settings page; in order to avoid layout changes there, a new style prop,overlay (boolean)
has been added to the component which will cause it to be absolutely positioned.Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
BR Panel
--rewards=staging=true
BR Settings Page
--rewards=staging=true
brave://rewards
and join rewardsReviewer Checklist:
After-merge Checklist:
changes has landed on.